[Table Visualization] remove legacy table and add table visualization #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
force-pushed
the
feature/table-clean-and-restore
branch
from
a23c898
to
95e64c8
Compare
ashwin-pc
reviewed
Sep 13, 2022
src/plugins/vis_type_table/public/table_vis_response_handler.ts
Outdated
Show resolved
Hide resolved
|
plan is to keep all the features but just replace it from angular to react. Then use this to replace the current table vis in v2.4. |
To convert the table visualization into React & OUI DataGrid component, in this PR, we did two main things: * clean out legacy angular code * restore table vis in react * Datagrid component does not support splitted grids. For future transfer to OUI Datagrid, we create a tableGroup in visData for splitted grids. issue resolved: opensearch-project#2212 https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2213a Signed-off-by: Anan Zhuang <ananzh@amazon.com> rename visTable back to opensearch_dashboards_table and add stronger type Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
force-pushed
the
feature/table-clean-and-restore
branch
from
95e64c8
to
0dd02d4
Compare
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Oct 25, 2022
…opensearch-project#2279) To convert the table visualization into React & OUI DataGrid component, in this PR, we did two main things: * clean out legacy angular code * restore table vis in react * Datagrid component does not support splitted grids. For future transfer to OUI Datagrid, we create a tableGroup in visData for splitted grids. issue resolved: opensearch-project#2212 https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2213a Signed-off-by: Anan Zhuang <ananzh@amazon.com> rename visTable back to opensearch_dashboards_table and add stronger type Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] add a plain datagrid component (opensearch-project#2390) implement a plain OuiDataGrid component use the basic pagenation, sort and format. Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] restore datagrid columns (opensearch-project#2411) * restore datagrid columns * display column title correctly * deangular and re-use formatted column * convert formatted column to data grid column * restore filter in and filter out value functions Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] restore pagination to table vis (opensearch-project#2461) * add pagination patically resolved: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] make table vis column resizable (opensearch-project#2464) * add resizable state to column Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] make table vis column sortable (opensearch-project#2502) * add sort state (asc | desc) to column * fix pagination issue Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] format table cell and restore showTotal feature (opensearch-project#2562) * format table cell to show Date and percent * restore showTotal feature: it allows table vis to show total, avg, min, max and count statics on count * fix some type errors Partically resolved: opensearch-project#2379 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization]restore export csv feature to table vis (opensearch-project#2568) * add addtional action in toolbar to allow export data to csv. there are two types of csv, raw and formatted. raw is the original data and formatted is to show formatted Date and percentage data when needed. * when table is not saved, export csv file will be named as unsaved-raw.csv if choose raw. when table is saved with a filename, it will be saved as [filename]-[raw/formatted].csv Partically resolved: opensearch-project#2379 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] split table in rows and columns This PR implement a group component TableVisGroupComponent utilizing TableVisComponent as sub component. It also adds a title to TableVisComponent. Partically resolved: opensearch-project#2379 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] remove local state * remove local col width state to allow split tables to fetch updated col width state * fix type errors in usePagination Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] remove repeated column from split tables Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization][BUG] partical rows option generate repeated metrics Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Oct 28, 2022
…opensearch-project#2279) To convert the table visualization into React & OUI DataGrid component, in this PR, we did two main things: * clean out legacy angular code * restore table vis in react * Datagrid component does not support splitted grids. For future transfer to OUI Datagrid, we create a tableGroup in visData for splitted grids. issue resolved: opensearch-project#2212 https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2213a Signed-off-by: Anan Zhuang <ananzh@amazon.com> rename visTable back to opensearch_dashboards_table and add stronger type Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] add a plain datagrid component (opensearch-project#2390) implement a plain OuiDataGrid component use the basic pagenation, sort and format. Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] restore datagrid columns (opensearch-project#2411) * restore datagrid columns * display column title correctly * deangular and re-use formatted column * convert formatted column to data grid column * restore filter in and filter out value functions Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] restore pagination to table vis (opensearch-project#2461) * add pagination patically resolved: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] make table vis column resizable (opensearch-project#2464) * add resizable state to column Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] make table vis column sortable (opensearch-project#2502) * add sort state (asc | desc) to column * fix pagination issue Partially resolve: opensearch-project#2305 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] format table cell and restore showTotal feature (opensearch-project#2562) * format table cell to show Date and percent * restore showTotal feature: it allows table vis to show total, avg, min, max and count statics on count * fix some type errors Partically resolved: opensearch-project#2379 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization]restore export csv feature to table vis (opensearch-project#2568) * add addtional action in toolbar to allow export data to csv. there are two types of csv, raw and formatted. raw is the original data and formatted is to show formatted Date and percentage data when needed. * when table is not saved, export csv file will be named as unsaved-raw.csv if choose raw. when table is saved with a filename, it will be saved as [filename]-[raw/formatted].csv Partically resolved: opensearch-project#2379 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization] split table in rows and columns (opensearch-project#2578) This PR implement a group component TableVisGroupComponent utilizing TableVisComponent as sub component. It also adds a title to TableVisComponent. Partically resolved: opensearch-project#2379 Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization][IMPROVE] remove repeated column from split tables (opensearch-project#2583) Currently, when we split table by columns, the split column is shown both in the table title and as a separate column. This is not needed. In this PR, we remove the repeated column in split tables in col. Partically resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization][BUG] remove local column width state (opensearch-project#2582) * remove local col width state to allow split tables to fetch updated col width state * fix type errors in usePagination Partially resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> [Table Visualization][BUG] partical rows shows metrics for all columns (opensearch-project#2648) Currently, when we enable Show partial rows in the Options panel, we see metrics been added to every column even though Show metrics for every bucket/level is not enabled. Metrics are added and returned when we enable the partial rows. This PR fixed the bug by slice the returned data to allow only the last set of metrices. Partially resolved: opensearch-project#2579 (comment) Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To convert the table visualization into React & OUI DataGrid component, in this PR, we did two main things:
Issues Resolved
#2212
#2213
Notes
This PR does not add up any tests or components. I will open separate issues for those tasks. Right now, from what I test, the visConfig is loaded correctly and visData are handled correctly. These two are needed to render the Datagrid component. Here are some example settings:
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr