Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D&D] Add index pattern info when loading embeddable #2363

Merged
merged 1 commit into from
Sep 15, 2022
Merged

[D&D] Add index pattern info when loading embeddable #2363

merged 1 commit into from
Sep 15, 2022

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Sep 15, 2022 •
edited
Loading

Description

Since index pattern is not included in the visualization state anymore, need to add the index pattern information so the embeddable can be loaded correctly on the dashboard.

Signed-off-by: abbyhu2000 abigailhu2000@gmail.com

Screen Shot 2022-09-14 at 7 01 49 PM

Issues Resolved

resolves #2362

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@abbyhu2000
Add index pattern info when loading embeddable
0eb7e63 
Since index pattern is not included in the visualization state anymore,
need to add the index pattern information so the embeddable can be loaded correctly.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 self-assigned this Sep 15, 2022
@abbyhu2000 abbyhu2000 marked this pull request as ready for review September 15, 2022 02:08
@abbyhu2000 abbyhu2000 requested a review from a team as a code owner September 15, 2022 02:08
@abbyhu2000 abbyhu2000 changed the title Add index pattern info when loading embeddable [D&D] Add index pattern info when loading embeddable Sep 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2363 (0eb7e63) into main (ab99eac) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2363      +/-   ##
==========================================
- Coverage   66.55%   66.54%   -0.01%     
==========================================
  Files        3170     3170              
  Lines       60316    60320       +4     
  Branches     9181     9181              
==========================================
- Hits        40142    40140       -2     
- Misses      17956    17986      +30     
+ Partials     2218     2194      -24
Impacted Files Coverage Δ
...ns/wizard/common/wizard_saved_object_attributes.ts 100.00% <ø> (ø)
...ins/wizard/public/embeddable/wizard_embeddable.tsx 1.00% <0.00%> (-0.03%) ⬇️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (-2.78%) ⬇️
packages/osd-test/src/junit_report_path.ts 62.50% <0.00%> (ø)
packages/osd-optimizer/src/run_optimizer.ts 23.52% <0.00%> (ø)
packages/osd-optimizer/src/log_optimizer_state.ts 4.54% <0.00%> (ø)
...ckages/osd-optimizer/src/report_optimizer_stats.ts 21.42% <0.00%> (ø)
...lugins/vis_type_vega/public/vega_view/vega_view.js 100.00% <0.00%> (ø)
...ns/vis_type_vega/public/vega_view/vega_map_view.js 54.34% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashwin-pc ashwin-pc merged commit dc0d7d5 into opensearch-project:main Sep 15, 2022
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 15, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 15, 2022
@abbyhu2000 @github-actions
Add index pattern info when loading embeddable (#2363)
059f16b 
Since index pattern is not included in the visualization state anymore,
need to add the index pattern information so the embeddable can be loaded correctly.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit dc0d7d5)
ashwin-pc pushed a commit that referenced this pull request Sep 15, 2022
@opensearch-trigger-bot @abbyhu2000
Add index pattern info when loading embeddable (#2363) (#2370)
0720f14 
Since index pattern is not included in the visualization state anymore,
need to add the index pattern information so the embeddable can be loaded correctly.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit dc0d7d5)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
opensearch-trigger-bot bot added a commit that referenced this pull request Sep 15, 2022
@opensearch-trigger-bot @github-actions
Add index pattern info when loading embeddable (#2363) (#2370)
1c94092 
Since index pattern is not included in the visualization state anymore,
need to add the index pattern information so the embeddable can be loaded correctly.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit dc0d7d5)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 0720f14)
joshuarrrr pushed a commit that referenced this pull request Sep 16, 2022
@opensearch-trigger-bot
Add index pattern info when loading embeddable (#2363) (#2370) (#2374)
3cb584b 
Since index pattern is not included in the visualization state anymore,
need to add the index pattern information so the embeddable can be loaded correctly.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit dc0d7d5)

Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
(cherry picked from commit 0720f14)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
@abbyhu2000 abbyhu2000 deleted the add_wizard_directly_to_dashboard branch September 16, 2022 15:42
@AMoo-Miki AMoo-Miki added enhancement New feature or request v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 5, 2022
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
@abbyhu2000 @sipopo
Add index pattern info when loading embeddable (opensearch-project#2363)
19b4a96 
Since index pattern is not included in the visualization state anymore,
need to add the index pattern information so the embeddable can be loaded correctly.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seraphjiang seraphjiang seraphjiang approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

Assignees

@abbyhu2000 abbyhu2000

Labels
backport 2.x enhancement New feature or request v2.4.0 'Issues and PRs related to version v2.4.0' vis builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Wizard can not display correctly on the dashboard
5 participants
@abbyhu2000 @codecov-commenter @seraphjiang @AMoo-Miki @ashwin-pc