[MD] Display error toast for create index pattern with data source #2506
Conversation
Signed-off-by: Su <szhongna@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
zhongnansu
assigned kristenTian, zengyan-amazon, mpabba3003 and zhongnansu and unassigned zhongnansu, zengyan-amazon, mpabba3003 and kristenTian
Codecov Report
@@ Coverage Diff @@
## main #2506 +/- ##
=======================================
Coverage 66.78% 66.78%
=======================================
Files 3201 3201
Lines 60913 60915 +2
Branches 9254 9255 +1
=======================================
+ Hits 40681 40683 +2
Misses 18019 18019
Partials 2213 2213
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -199,7 +199,14 @@ export async function getIndices({ | |||
| pattern, | |||
| showAllIndices, | |||
| dataSourceId, | |||
| }).catch(() => []); | |||
| }).catch((error) => { | |||
| // swallow the errors to be backwards compatible with non-data-source use case | |||
There was a problem hiding this comment.
there is also line 103 could use the same :P
There was a problem hiding this comment.
line 103 maps to getIndicesViaSearch which is specifically for CCS use case as a step 2 request. But for CCS it also requires step 1 querying against local cluster. Even we added the same logic to step 2, the code won't be able to reach there, because the error will be thrown at step 1 already. Let's leave as it is.
There was a problem hiding this comment.
My point was the call through search client in getIndicesViaSearch itself could also have error. And it's a different route from the resolve api. But it's not blocking this PR though.
…pensearch-project#2506) (opensearch-project#2526) * add error toast for create index pattern with data source * update change log Signed-off-by: Su <szhongna@amazon.com> (cherry picked from commit 0e742b9)
…pensearch-project#2506) * add error toast for create index pattern with data source Signed-off-by: Su <szhongna@amazon.com> * update change log Signed-off-by: Su <szhongna@amazon.com> Signed-off-by: Su <szhongna@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Signed-off-by: Su szhongna@amazon.com
Description
Display error toast for create index pattern with data source.
Make use of the existing toast component instead of swallowing error, we generate the pop-up for data source use case in index pattern
Issues Resolved
#2285
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr