[PURIFY][BUILD] Removes oss flag from underlaying packages #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
|
✅ DCO Check Passed 29d3b7e |
kavilla
approved these changes
Apr 6, 2021
| } | ||
|
|
||
| productionProjects.forEach((project) => { | ||
| if (project.getBuildConfig().oss === false) { |
There was a problem hiding this comment.
should these ever be false again? mostly likely will be undefined right?
There was a problem hiding this comment.
Yeah actually we can remove it, just kept it for safe side.
4 tasks
wanglam
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 18, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Soni mihirsoni.123@gmail.com
Issues : #26
This PR removes underlaying isOOS flag being used for build artifacts from
osd-pmandosd-optimizer