[MD] UX updates on data source page & validation changes #2521

mpabba3003 · 2022-10-06T00:09:53Z

Description

This PR includes feedback changes received from #2399 & opensearch-project/ux#16

Issues Resolved

opensearch-project/ux#18
opensearch-project/ux#21
opensearch-project/ux#22
opensearch-project/ux#28
opensearch-project/ux#30
opensearch-project/ux#31
opensearch-project/ux#32
opensearch-project/ux#33
opensearch-project/ux#34
opensearch-project/ux#35
opensearch-project/ux#36
#2426
#2489
#2438

SCREENSHOTS

Home.-.OpenSearch.Dashboards.mp4

Update password:

dfg.-.OpenSearch.Dashboards.mp4

Check List

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

...management/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx

src/plugins/data_source_management/public/components/text_content/text_content.ts

..._source_management/public/components/create_data_source_wizard/create_data_source_wizard.tsx

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

seraphjiang · 2022-10-06T02:43:16Z

could we add screenshot

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

mpabba3003 · 2022-10-06T15:44:55Z

could we add screenshot

Added a video

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

codecov-commenter · 2022-10-06T16:20:14Z

Codecov Report

Merging #2521 (cbd6c84) into main (4095e12) will decrease coverage by 0.02%.
The diff coverage is 89.56%.

@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
- Coverage   66.76%   66.73%   -0.03%     
==========================================
  Files        3201     3201              
  Lines       60943    60946       +3     
  Branches     9258     9266       +8     
==========================================
- Hits        40687    40673      -14     
- Misses      18041    18055      +14     
- Partials     2215     2218       +3

Impacted Files	Coverage Δ
.../public/components/create_button/create_button.tsx	`100.00% <ø> (ø)`
src/plugins/data_source_management/public/types.ts	`100.00% <ø> (ø)`
...components/create_form/create_data_source_form.tsx	`83.33% <68.96%> (-16.67%)`	⬇️
...e_data_source_wizard/create_data_source_wizard.tsx	`90.32% <81.25%> (-9.68%)`	⬇️
...te_data_source_wizard/components/header/header.tsx	`100.00% <100.00%> (ø)`
...components/data_source_table/data_source_table.tsx	`96.82% <100.00%> (-3.18%)`	⬇️
...ent/public/components/text_content/text_content.ts	`100.00% <100.00%> (ø)`
...omponents/validation/datasource_form_validation.ts	`100.00% <100.00%> (ø)`
...plugins/management/public/utils/management_item.ts	`91.66% <100.00%> (+0.75%)`	⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

zengyan-amazon · 2022-10-06T17:26:56Z

src/plugins/management/public/types.ts

@@ -90,6 +90,7 @@ export interface CreateManagementItemArgs {
 title: string;
 tip?: string;
 order?: number;
+ showExperimentalBadge?: boolean;


we may consider to support other badge types to make this more generic. e.g. let outer component to optionally pass a badge type.
Not a blocker for this change though.

kristenTian · 2022-10-06T18:28:28Z

am waiting for tests to pass to approve and merge, could you rebase first due to the changelog conflict?

# Conflicts: # CHANGELOG.md

mpabba3003 · 2022-10-06T18:31:40Z

am waiting for tests to pass to approve and merge, could you rebase first due to the changelog conflict?

@kristenTian Tests passed. But got a merge conflict as your PR got merged.

opensearch-trigger-bot · 2022-10-06T20:51:22Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2521-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21a173b6d3e323038eafce121dffae28d0362299
# Push it to GitHub
git push --set-upstream origin backport/backport-2521-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2521-to-2.x.

opensearch-trigger-bot · 2022-10-06T22:04:52Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2521-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21a173b6d3e323038eafce121dffae28d0362299
# Push it to GitHub
git push --set-upstream origin backport/backport-2521-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2521-to-2.x.

…project#2521) * new ux changes v2.4.0 Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * new UX changes and Validation changed Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding change log for data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * removing un-used text content Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

…project#2521) * new ux changes v2.4.0 Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * new UX changes and Validation changed Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding change log for data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * removing un-used text content Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 21a173b)

* new ux changes v2.4.0 Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * new UX changes and Validation changed Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding change log for data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * removing un-used text content Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 21a173b)

* new ux changes v2.4.0 Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * new UX changes and Validation changed Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding change log for data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * removing un-used text content Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 21a173b) Co-authored-by: Manideep Pabba <109986843+mpabba3003@users.noreply.github.com>

…project#2521) (opensearch-project#2546) * new ux changes v2.4.0 Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * new UX changes and Validation changed Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding change log for data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * removing un-used text content Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 21a173b) Co-authored-by: Manideep Pabba <109986843+mpabba3003@users.noreply.github.com>

…project#2521) * new ux changes v2.4.0 Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * new UX changes and Validation changed Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * refactoring duplicate title validation on edit data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * replacing eui toasts with notifications toasts Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating testcases after updating toasts methods Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding change log for data source Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * adding password validation on update stored password modal Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * removing un-used text content Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>

mpabba3003 added 2 commits October 4, 2022 10:28

new ux changes v2.4.0

b142038

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

new UX changes and Validation changed

f90071b

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

mpabba3003 requested a review from a team as a code owner October 6, 2022 00:09

mpabba3003 added ux / ui Improvements or additions to user experience, flows, components, UI elements multiple datasource multiple datasource project v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 6, 2022

mpabba3003 added 2 commits October 5, 2022 17:18

Merge remote-tracking branch 'origin/main' into new_ux_changes

53e5cb0

refactoring duplicate title validation on edit data source

35bc5b0

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

zhongnansu reviewed Oct 6, 2022

View reviewed changes

kristenTian reviewed Oct 6, 2022

View reviewed changes

..._source_management/public/components/create_data_source_wizard/create_data_source_wizard.tsx Show resolved Hide resolved

replacing eui toasts with notifications toasts

9bc6cc0

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

mpabba3003 requested review from zhongnansu and kristenTian October 6, 2022 01:55

seraphjiang requested review from a team, zengyan-amazon and KrooshalUX October 6, 2022 02:42

mpabba3003 added 2 commits October 6, 2022 08:34

updating testcases after updating toasts methods

ac5732e

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

adding change log for data source

4dcff08

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

adding password validation on update stored password modal

78ea794

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

removing un-used text content

b1fb3c9

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

zengyan-amazon reviewed Oct 6, 2022

View reviewed changes

zengyan-amazon previously approved these changes Oct 6, 2022

View reviewed changes

zhongnansu added the backport 2.x label Oct 6, 2022

Merge remote-tracking branch 'origin/main' into new_ux_changes

cbd6c84

# Conflicts: # CHANGELOG.md

mpabba3003 dismissed zengyan-amazon’s stale review via cbd6c84 October 6, 2022 18:30

kristenTian approved these changes Oct 6, 2022

View reviewed changes

zengyan-amazon approved these changes Oct 6, 2022

View reviewed changes

kristenTian merged commit 21a173b into opensearch-project:main Oct 6, 2022

zhongnansu added backport 2.x and removed backport 2.x labels Oct 6, 2022

noCharger mentioned this pull request Oct 6, 2022

[MD] Identify the source for duplicate index patterns #2442

Closed

zhongnansu added backport 2.x and removed backport 2.x labels Oct 11, 2022

opensearch-trigger-bot bot mentioned this pull request Oct 11, 2022

[Backport 2.x] [MD] UX updates on data source page & validation changes #2546

Merged

AMoo-Miki added the enhancement New feature or request label Nov 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MD] UX updates on data source page & validation changes #2521

[MD] UX updates on data source page & validation changes #2521

mpabba3003 commented Oct 6, 2022 •

edited

Loading

seraphjiang commented Oct 6, 2022

mpabba3003 commented Oct 6, 2022

codecov-commenter commented Oct 6, 2022 •

edited

Loading

zengyan-amazon Oct 6, 2022

kristenTian commented Oct 6, 2022 •

edited

Loading

mpabba3003 commented Oct 6, 2022

opensearch-trigger-bot bot commented Oct 6, 2022

opensearch-trigger-bot bot commented Oct 6, 2022

[MD] UX updates on data source page & validation changes #2521

[MD] UX updates on data source page & validation changes #2521

Conversation

mpabba3003 commented Oct 6, 2022 • edited Loading

Description

Issues Resolved

SCREENSHOTS

Check List

seraphjiang commented Oct 6, 2022

mpabba3003 commented Oct 6, 2022

codecov-commenter commented Oct 6, 2022 • edited Loading

Codecov Report

zengyan-amazon Oct 6, 2022

Choose a reason for hiding this comment

kristenTian commented Oct 6, 2022 • edited Loading

mpabba3003 commented Oct 6, 2022

opensearch-trigger-bot bot commented Oct 6, 2022

opensearch-trigger-bot bot commented Oct 6, 2022

mpabba3003 commented Oct 6, 2022 •

edited

Loading

codecov-commenter commented Oct 6, 2022 •

edited

Loading

kristenTian commented Oct 6, 2022 •

edited

Loading