Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] new UX changes for password fields and update password modal in data source management #2532

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

mpabba3003
Copy link
Contributor

Signed-off-by: mpabba3003 amazonmanideep@gmail.com

Description

new UX changes for password fields and update password modal in data source management

Issues Resolved

[List any issues this PR will resolve]
opensearch-project/ux#34

SCREENSHOTS

Data.Sources.-.OpenSearch.Dashboards.1.mp4

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…source management

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
@mpabba3003 mpabba3003 requested a review from a team as a code owner October 7, 2022 14:53
@mpabba3003 mpabba3003 added ux / ui Improvements or additions to user experience, flows, components, UI elements backport 2.x multiple datasource multiple datasource project v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 7, 2022
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2532 (5b68803) into main (ac07159) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2532   +/-   ##
=======================================
  Coverage   66.74%   66.74%           
=======================================
  Files        3201     3201           
  Lines       60948    60951    +3     
  Branches     9267     9267           
=======================================
+ Hits        40679    40682    +3     
  Misses      18052    18052           
  Partials     2217     2217           
Impacted Files Coverage Δ
...ent/public/components/text_content/text_content.ts 100.00% <100.00%> (ø)
...ared/static/forms/hook_form_lib/hooks/use_field.ts 65.70% <0.00%> (-0.97%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-0.89%) ⬇️
packages/osd-optimizer/src/node/cache.ts 52.77% <0.00%> (+2.77%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

defaultMessage: 'Updated password',
}
);
export const CONFIRM_NEW_PASSWORD_TEXT = i18n.translate(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive called this out in some of the other MD PR's, but lets move the translate functions into the react components. That way we have realtime translations instead of static translations that only run during compile time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I will resolve it today in a different PR as many PRs will have conflicts if I do it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpabba3003!

@kristenTian kristenTian merged commit 9f6bfc0 into opensearch-project:main Oct 10, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2532-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f6bfc01d94e4100e790857985bf2e1b648160af
# Push it to GitHub
git push --set-upstream origin backport/backport-2532-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2532-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2532-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f6bfc01d94e4100e790857985bf2e1b648160af
# Push it to GitHub
git push --set-upstream origin backport/backport-2532-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2532-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2022
…data source management (#2532)

* nex ux changes for password fields and update password modal in data source management

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

* update change log

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
(cherry picked from commit 9f6bfc0)
kristenTian pushed a commit that referenced this pull request Oct 12, 2022
…data source management (#2532) (#2553)

* nex ux changes for password fields and update password modal in data source management

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

* update change log

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
(cherry picked from commit 9f6bfc0)

Co-authored-by: Manideep Pabba <109986843+mpabba3003@users.noreply.github.com>
@AMoo-Miki AMoo-Miki added the enhancement New feature or request label Nov 5, 2022
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Dec 1, 2022
…data source management (opensearch-project#2532) (opensearch-project#2553)

* nex ux changes for password fields and update password modal in data source management

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

* update change log

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
(cherry picked from commit 9f6bfc0)

Co-authored-by: Manideep Pabba <109986843+mpabba3003@users.noreply.github.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
…data source management (opensearch-project#2532)

* nex ux changes for password fields and update password modal in data source management

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

* update change log

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>

Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants