Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD]Add column service to index pattern & Register data source column #2542

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

kristenTian
Copy link
Contributor

Signed-off-by: Kristen Tian tyarong@amazon.com

Description

Adding data source column to index pattern table.

  • Created column service in index pattern management public plugin, so that other plugin can register column to index pattern table
  • Created data source column and register it to index pattern table, the column cell will show
    • Data source title if present
    • Deleted tag if configured data source deleted

image

Issues Resolved

UX mock up:
image

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@kristenTian kristenTian added the multiple datasource multiple datasource project label Oct 10, 2022
@kristenTian kristenTian self-assigned this Oct 10, 2022
@kristenTian kristenTian requested a review from a team as a code owner October 10, 2022 18:43
@KrooshalUX
Copy link

KrooshalUX commented Oct 10, 2022

LGTM, thanks for the additional thinking around the deleted state. For speed to release for 2.4, I will put some notes for the 2.5 release around column organization for the default tag etc.

Signed-off-by: Kristen Tian <tyarong@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2542 (b49c6e0) into main (d6197a7) will decrease coverage by 0.00%.
The diff coverage is 18.18%.

❗ Current head b49c6e0 differs from pull request most recent head 394aa85. Consider uploading reports for the commit 394aa85 to get more accurate results

@@            Coverage Diff             @@
##             main    #2542      +/-   ##
==========================================
- Coverage   66.73%   66.72%   -0.01%     
==========================================
  Files        3201     3202       +1     
  Lines       60958    60969      +11     
  Branches     9271     9273       +2     
==========================================
+ Hits        40678    40684       +6     
- Misses      18062    18067       +5     
  Partials     2218     2218              
Impacted Files Coverage Δ
...c/plugins/index_pattern_management/public/index.ts 0.00% <ø> (ø)
...nt/public/service/column_service/column_service.ts 0.00% <0.00%> (ø)
...public/service/index_pattern_management_service.ts 0.00% <0.00%> (ø)
...ndex_pattern_management/public/components/utils.ts 44.00% <66.66%> (+3.09%) ⬆️
packages/osd-optimizer/src/node/cache.ts 52.77% <0.00%> (+2.77%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kristenTian kristenTian merged commit 2600196 into opensearch-project:main Oct 11, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2542-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2600196224214fac153c4f0380059bb2a48a8ce7
# Push it to GitHub
git push --set-upstream origin backport/backport-2542-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2542-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2022
)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit 2600196)
kristenTian added a commit that referenced this pull request Oct 12, 2022
) (#2558)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
(cherry picked from commit 2600196)

Co-authored-by: Kristen Tian <105667444+kristenTian@users.noreply.github.com>
@AMoo-Miki AMoo-Miki added enhancement New feature or request v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 5, 2022
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
…ensearch-project#2542)

Signed-off-by: Kristen Tian <tyarong@amazon.com>

Signed-off-by: Kristen Tian <tyarong@amazon.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request multiple datasource multiple datasource project v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants