-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last Updated Timestamp for visbuilder savedobject is getting Generated #2628
Last Updated Timestamp for visbuilder savedobject is getting Generated #2628
Conversation
1064e92
to
9dc8436
Compare
3fde491
to
edaff9d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2628 +/- ##
==========================================
+ Coverage 66.78% 66.79% +0.01%
==========================================
Files 3207 3207
Lines 61175 61175
Branches 9329 9329
==========================================
+ Hits 40855 40863 +8
+ Misses 18084 18079 -5
+ Partials 2236 2233 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AbhishekReddy1127 This is great and such a cool bean. Currently PR is outdated and you could rebase it. I could approve again after you rebase and solve the conflict. |
@AbhishekReddy1127 would you be able to rebase this PR? Let us know if you need some assistance with that! Thanks! |
Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
89a0dfa
edaff9d
to
89a0dfa
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2628-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a16fe4064257d72059307717a3e26023142d9b7a
# Push it to GitHub
git push --set-upstream origin backport/backport-2628-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…ed (#2628) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit a16fe40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…ed (#2628) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit a16fe40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…ed (#2628) (#2742) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit a16fe40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ed (#2628) (#2743) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit a16fe40) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ed (opensearch-project#2628) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
…ed (opensearch-project#2628) Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Signed-off-by: AbhishekReddy1127 nallamsa@amazon.com
Description
The Savedobjects for the VisBuilder are generating the last updated timestamp
ScreenShot:
Issues Resolved
#2463
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr