Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] add plugins to root #281

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 10, 2021

Description

Adding plugins to root directory and updates the generate
plugin integration test to not delete the directory automatically.

It cleans up the directory and leaves the gitignore and the parent
directory. This directory is for chokidar and a start up check
the fails to start if the directory isn't there.

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • [ x Commits are signed per the DCO using --signoff

Adding plugins to root directory and updates the generate
plugin integration test to not delete the directory automatically.

It cleans up the directory and leaves the gitignore and the parent
directory. This directory is for chokidar and a start up check
the fails to start if the directory isn't there.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@odfe-release-bot
Copy link

✅   DCO Check Passed 4751b7d

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks.

@seraphjiang seraphjiang merged commit b12ea28 into opensearch-project:main Apr 12, 2021
@kavilla kavilla deleted the add-root-plugins branch April 27, 2021 20:57
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Mar 8, 2024
…ect#281)

* remove management workspace (opensearch-project#278)

* remove management workspace

* delete unnecessary code comments

* delete comments
# Conflicts:
#	src/core/public/index.ts
#	src/core/public/utils/index.ts
#	src/core/utils/constants.ts
#	src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx
#	src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
#	src/plugins/workspace/server/workspace_client.ts

* update typescript version to 4.6.4

* delete useless code and add a lost yarn.lock

* delete yarn.lock
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
…ect#281)

* remove management workspace (opensearch-project#278)

* remove management workspace

* delete unnecessary code comments

* delete comments
# Conflicts:
#	src/core/public/index.ts
#	src/core/public/utils/index.ts
#	src/core/utils/constants.ts
#	src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx
#	src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
#	src/plugins/workspace/server/workspace_client.ts

* update typescript version to 4.6.4

* delete useless code and add a lost yarn.lock

* delete yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants