Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme URL #284

Closed
wants to merge 2 commits into from
Closed

Fix readme URL #284

wants to merge 2 commits into from

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented Apr 13, 2021

Fix readme with proper instructions to clone the repo for OpenSearch-Dashboards

Description

Fixes the URL for this repo

Issues Resolved

No issue opened yet

Fix readme with proper instructions to clone the repo for OpenSearch-Dashboards
@odfe-release-bot
Copy link

❌   DCO Check Failed 2766fab
Run ./dev-tools/signoff-check.sh remotes/origin/main 2766fabbb7a19e994f9e266d28477f6a55fa0357 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

mihirsoni
mihirsoni previously approved these changes Apr 13, 2021
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkowall for the change. LGTM !!

@mihirsoni mihirsoni added the docs Improvements or additions to documentation label Apr 13, 2021
ananzh
ananzh previously approved these changes Apr 13, 2021
boktorbb
boktorbb previously approved these changes Apr 13, 2021
@kavilla
Copy link
Member

kavilla commented Apr 13, 2021

Looks good just the commit needs a sign-off

Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
@jkowall jkowall dismissed stale reviews from boktorbb, ananzh, and mihirsoni via 4ff1201 April 13, 2021 19:22
@jkowall
Copy link
Contributor Author

jkowall commented Apr 13, 2021

Looks good just the commit needs a sign-off

Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

Thanks, I hope I did it right. I'm used to CLA not DCO :)

@odfe-release-bot
Copy link

❌   DCO Check Failed 4ff1201
Run ./dev-tools/signoff-check.sh remotes/origin/main 4ff1201baf4026b183ca4b66493bf48ee62a336e to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@kavilla
Copy link
Member

kavilla commented Apr 13, 2021

Looks good just the commit needs a sign-off
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

Thanks, I hope I did it right. I'm used to CLA not DCO :)

Yes perfect! The only thing is it is the bot is checking each commit to be signed off, so for it to pass the automated checks, you should be able to do an interactive rebase to squash the commits so it's one big commit that includes the sign off with the first commit or amend the first commit to also have the sign off message.

The bot basically only check if the commit description has Signed-off-by: name <email>.

Let me know if I should clarify anything, and thank you for the help!

@jkowall jkowall closed this Apr 13, 2021
@jkowall jkowall deleted the patch-1 branch April 13, 2021 23:16
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Mar 15, 2024
* Add workspace create page

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Address PR comments

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Add more comments

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Add example for dependencies field in App

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Separate workspace feature selector

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Correct example for dependencies

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove unclear icon and defaultVISTheme input

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove unclear dependencies feature

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove states and fix onChange fired after mount

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
* Add workspace create page

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Address PR comments

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Add more comments

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Add example for dependencies field in App

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Separate workspace feature selector

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Correct example for dependencies

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove unclear icon and defaultVISTheme input

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove unclear dependencies feature

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove states and fix onChange fired after mount

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants