Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify instructions in README #286

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Clarify instructions in README #286

merged 2 commits into from
Apr 14, 2021

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented Apr 13, 2021

Description

Added link to the opensearch dev guide.
Fixed the URL for the clone to work for OpenSearch Dashboards

Signed-off-by: Jonah Kowall jkowall@kowall.net

Added link to the opensearch dev guide.
Fixed the URL for the clone to work for OpenSearch Dashboards

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
@odfe-release-bot
Copy link

✅   DCO Check Passed d00df7e

mihirsoni
mihirsoni previously approved these changes Apr 13, 2021
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @jkowall LGTM !!!

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nits.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Removed "repo" from text and added https to the link

Signed-off-by: Jonah Kowall jkowall@kowall.net
@odfe-release-bot
Copy link

✅   DCO Check Passed 4901475

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@mihirsoni mihirsoni merged commit 08b2934 into opensearch-project:main Apr 14, 2021
kavilla pushed a commit that referenced this pull request May 21, 2021
* Clarify instructions

Added link to the opensearch dev guide.
Fixed the URL for the clone to work for OpenSearch Dashboards

Signed-off-by: Jonah Kowall <jkowall@kowall.net>

* Minor README fixed per discussion

Removed "repo" from text and added https to the link

Signed-off-by: Jonah Kowall jkowall@kowall.net
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Mar 8, 2024
* revert unnecessary changes to recently viewed component

refactor nav link updater so that the displayed links can be customized,
this is majority required by workspace as with workspace, user would be
able to config what features(plugins) then want to see for a workspace,
this requires to filter out those links that are not configured by the
user.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* fix test snapshot

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* tweak comments

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
* revert unnecessary changes to recently viewed component

refactor nav link updater so that the displayed links can be customized,
this is majority required by workspace as with workspace, user would be
able to config what features(plugins) then want to see for a workspace,
this requires to filter out those links that are not configured by the
user.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* fix test snapshot

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* tweak comments

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants