Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable CI tests for feature branches #2908

Merged

Conversation

ashwin-pc
Copy link
Member

Signed-off-by: Ashwin P Chandran ashwinpc@amazon.com

Description

Reenables branch protections for feature branch PR's

Issues Resolved

#2887

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc requested a review from a team as a code owner November 21, 2022 22:39
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #2908 (0640b46) into main (311fe91) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2908   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files        3219     3219           
  Lines       61450    61450           
  Branches     9417     9417           
=======================================
+ Hits        40969    40973    +4     
+ Misses      18234    18231    -3     
+ Partials     2247     2246    -1     
Impacted Files Coverage Δ
packages/osd-optimizer/src/node/cache.ts 52.63% <0.00%> (+2.63%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

Whoever merges this can we make sure the commit is cleaned up for audit reasons.

@kavilla kavilla added the ci label Nov 23, 2022
@joshuarrrr joshuarrrr merged commit 808129b into opensearch-project:main Nov 24, 2022
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
* Reenable CI tests for feature branches

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
* Reenable CI tests for feature branches

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
* Reenable CI tests for feature branches

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Sergey Osipov <sipopo@yandex.ru>
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch-Dashboards that referenced this pull request Jan 13, 2023
* Reenable CI tests for feature branches

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
* Reenable CI tests for feature branches

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
* Reenable CI tests for feature branches

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants