-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x][Manual][Table Visualization] Replace table visualization with React and DataGrid (#2863) #3198
[Backport 2.x][Manual][Table Visualization] Replace table visualization with React and DataGrid (#2863) #3198
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #3198 +/- ##
==========================================
- Coverage 66.68% 66.40% -0.28%
==========================================
Files 3220 3199 -21
Lines 61544 61199 -345
Branches 9432 9415 -17
==========================================
- Hits 41041 40642 -399
- Misses 18262 18315 +53
- Partials 2241 2242 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5511f60
to
b07c2c9
Compare
…Grid (opensearch-project#2863) * [Table Visualization] Replace table visualization with React and DataGrid In this PR, we add back functions to make new table usage to be consistent with the replaced one. * total function * percentage column * filter in/out Meanwhile, we also add back server. Functional tests are removed. We will add new functional test in opensearch-dashboards-functional-test repo. We also clean out some legacy codes. Issue Resolved: opensearch-project#2855 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * add some data-test-subj and fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix PR comments and add unit tests Signed-off-by: Anan Zhuang <ananzh@amazon.com> * remove listenOnChange Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 9eedb8e)
b07c2c9
to
b7bc495
Compare
…Grid (#2863) (#3198) * [Table Visualization] Replace table visualization with React and DataGrid In this PR, we add back functions to make new table usage to be consistent with the replaced one. * total function * percentage column * filter in/out Meanwhile, we also add back server. Functional tests are removed. We will add new functional test in opensearch-dashboards-functional-test repo. We also clean out some legacy codes. Issue Resolved: #2855 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * add some data-test-subj and fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix PR comments and add unit tests Signed-off-by: Anan Zhuang <ananzh@amazon.com> * remove listenOnChange Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 9eedb8e) Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 51ddbf6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3198-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51ddbf69ec860696489ba8f5ce514d5530f644e2
# Push it to GitHub
git push --set-upstream origin backport/backport-3198-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…Grid (#2863) (#3198) (#3221) * [Table Visualization] Replace table visualization with React and DataGrid In this PR, we add back functions to make new table usage to be consistent with the replaced one. * total function * percentage column * filter in/out Meanwhile, we also add back server. Functional tests are removed. We will add new functional test in opensearch-dashboards-functional-test repo. We also clean out some legacy codes. Issue Resolved: #2855 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * add some data-test-subj and fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix PR comments and add unit tests Signed-off-by: Anan Zhuang <ananzh@amazon.com> * remove listenOnChange Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 9eedb8e) Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 51ddbf6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>
In this PR, we add back functions to make new table usage to be consistent with the replaced one.
Meanwhile, we also add back server. Functional tests are removed. We will add new functional test in opensearch-dashboards-functional-test repo. We also clean out some legacy codes.
Issue Resolved:
#2855
Signed-off-by: Anan Zhuang ananzh@amazon.com
Signed-off-by: Anan Zhuang ananzh@amazon.com
Signed-off-by: Anan Zhuang ananzh@amazon.com
Signed-off-by: Anan Zhuang ananzh@amazon.com
Signed-off-by: Anan Zhuang ananzh@amazon.com
(cherry picked from commit 9eedb8e)
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr