Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Update MAINTAINERS.md #3338

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jan 26, 2023

Description

Coming from opensearch-project/.github#121, updated MAINTAINERS.md to match opensearch-project recommended format. Also modify this file to include all the missing updates.

Since we won't include this in release, ignore CHANGELOG.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added backport 1.3 Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jan 26, 2023
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jan 27, 2023
Coming from opensearch-project/.github#121, updated MAINTAINERS.md
to match opensearch-project recommended format. Also modify this file
to include all the missing updates.

Backport PR:
opensearch-project#3338

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh mentioned this pull request Jan 27, 2023
7 tasks
Coming from opensearch-project/.github#121, updated MAINTAINERS.md
to match opensearch-project recommended format. Also modify this file
to include all the missing updates.

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@joshuarrrr joshuarrrr merged commit a983397 into opensearch-project:1.x Jan 30, 2023
joshuarrrr pushed a commit that referenced this pull request Jan 30, 2023
Coming from opensearch-project/.github#121, updated MAINTAINERS.md
to match opensearch-project recommended format. Also modify this file
to include all the missing updates.

Backport PR:
#3338

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3338-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a9833979b822791e6231ec17864f17d2bfc22d72
# Push it to GitHub
git push --set-upstream origin backport/backport-3338-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-3338-to-1.3.

@joshuarrrr joshuarrrr added not in release PRs backported to already shipped releases with no future release planned v1.3.9 and removed not in release PRs backported to already shipped releases with no future release planned labels Mar 6, 2023
@ashwin-pc ashwin-pc changed the title [1.x] Update MAINTAINERS.md [Backport 1.x] Update MAINTAINERS.md Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v1.3.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants