Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Replace EuiLoadingElastic to EuiLoadingSpinner #337

Merged
merged 1 commit into from
May 8, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented May 7, 2021

Signed-off-by: Anan Zhuang ananzh@amazon.com

Description

We found some logo hidden in Stack Management > Saved Objects > Import > select a file > Import> Elastic logo (spinner)

Issues Resolved

#338

Work

Replace EuiLoadingElastic to EuiLoadingSpinner.
Test(local): unit and integration

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh added the bug Something isn't working label May 7, 2021
@ananzh ananzh requested review from mihirsoni, kavilla and boktorbb May 7, 2021 23:23
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 7c29eb9

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!! Thanks @ananzh

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavilla
Copy link
Member

kavilla commented May 8, 2021

Functional tests work ! Thanks

@kavilla kavilla merged commit e73c536 into opensearch-project:main May 8, 2021
@kavilla kavilla linked an issue May 10, 2021 that may be closed by this pull request
kavilla pushed a commit that referenced this pull request May 21, 2021
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh deleted the fix_es_logo branch June 21, 2021 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Importing saved objects shows elastic logo
5 participants