[Manual backport 1.x] Updates NOTICE file, adds validation to GitHub CI & Corrects NOTICE f… #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristenTian
changed the title
…#3051) * Aligns NOTICE with rules outlined in opensearch-project/.github#21. * Adds NOTICE validation to the build and test workflow. * Fixes product name discrepancies between repository NOTICE file and the generated NOTICE file for the build. * Skips template-izing the build and test workflow since that's being worked on in opensearch-project#2991. Resolves opensearch-project#765 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>
* Corrects NOTICE file copyright date range * Follow-up on opensearch-project#3051 Resolves opensearch-project#765 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
kristenTian
added
the
Skip-Changelog
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 1.x #3453 +/- ##
==========================================
+ Coverage 67.45% 67.50% +0.05%
==========================================
Files 3044 3044
Lines 58697 58692 -5
Branches 8902 8902
==========================================
+ Hits 39592 39619 +27
+ Misses 16952 16925 -27
+ Partials 2153 2148 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Do we know that 1.x does not use any of those software removed from the NOTICE file? I have a feeling that we intentionally left these changes out of 1.x. |
joshuarrrr
previously requested changes
Feb 22, 2023
|
@AMoo-Miki This PR also includes a workflow step to validate that the notice file is accurate and it passes that step. I also manually validated the ones that were removed and they dont exist in the repo. |
joshuarrrr
approved these changes
Mar 10, 2023
ashwin-pc
approved these changes
Mar 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
…CI & Corrects NOTICE f… (#3453) * Updates NOTICE file, adds validation to GitHub CI (#3051) * Aligns NOTICE with rules outlined in opensearch-project/.github#21. * Adds NOTICE validation to the build and test workflow. * Fixes product name discrepancies between repository NOTICE file and the generated NOTICE file for the build. * Skips template-izing the build and test workflow since that's being worked on in #2991. Resolves #765 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * Corrects NOTICE file copyright date range (#3308) * Corrects NOTICE file copyright date range * Follow-up on #3051 Resolves #765 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> --------- Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit bf1c65f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 13, 2023
…CI & Corrects NOTICE f… (#3453) (#3596) * Updates NOTICE file, adds validation to GitHub CI (#3051) * Aligns NOTICE with rules outlined in opensearch-project/.github#21. * Adds NOTICE validation to the build and test workflow. * Fixes product name discrepancies between repository NOTICE file and the generated NOTICE file for the build. * Skips template-izing the build and test workflow since that's being worked on in #2991. Resolves #765 * Corrects NOTICE file copyright date range (#3308) * Corrects NOTICE file copyright date range * Follow-up on #3051 Resolves #765 * Update CHANGELOG.md --------- (cherry picked from commit bf1c65f) Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ile copyright date range
Resolves #765
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr