Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/alias js client #3469

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

joshuarrrr
Copy link
Member

Description

Add aliased opensearch js client as dependency to enable usage of @opensearch-project/opensearch@^2.x features without breaking plugins that directly depend on 1.x.

[Multiple Data Sources] Update data_source plugin opensearch client usage to 2.x

Issues Resolved

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Enable usage of `@opensearch-project/opensearch@^2.x` features without breaking plugins that directly depend on `1.x`

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3469 (bcdc5c8) into 2.x (17ca299) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x    #3469      +/-   ##
==========================================
- Coverage   66.54%   66.53%   -0.01%     
==========================================
  Files        3203     3203              
  Lines       61397    61397              
  Branches     9453     9453              
==========================================
- Hits        40859    40853       -6     
- Misses      18284    18288       +4     
- Partials     2254     2256       +2     
Flag Coverage Δ
Linux 66.48% <100.00%> (-0.01%) ⬇️
Windows 66.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/plugins/data_source/server/client/client_pool.ts 58.82% <ø> (ø)
...gins/data_source/server/client/configure_client.ts 66.03% <ø> (ø)
src/plugins/data_source/server/lib/error.ts 100.00% <ø> (ø)
...ource/server/client/configure_client.test.mocks.ts 100.00% <100.00%> (ø)
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 51.31% <0.00%> (-2.64%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhongnansu zhongnansu merged commit d40da8f into opensearch-project:2.x Feb 21, 2023
@joshuarrrr joshuarrrr deleted the chore/alias-js-client branch February 21, 2023 20:43
@joshuarrrr joshuarrrr mentioned this pull request Feb 22, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants