Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.6] [Manual][Backport 2.x] Relax Node.js version to ^14.20.1 and bump .nvmrc to v14.21.3 #3463 #3486

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4d1a531 from #3479.

…3463) (#3479)

* `engines.node` is relaxed from `14.20.1` to `^14.20.1`: yarn and OSD will allow versions 14.20.1 or greater, but less than 15, to be used but do not impose upgrading to avoid being a breaking change. Users will be able to install any version of Node.js that satisfies `^14.20.1`, moving ahead without waiting for a change in OSD when new versions are released.
* `.nvmrc` is bumped to the latest security patch: `14.21.3`

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 4d1a531)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner February 22, 2023 21:22
@joshuarrrr joshuarrrr added autocut Skip the changelog verification check on backports v2.6.0 labels Feb 22, 2023
@AMoo-Miki AMoo-Miki marked this pull request as draft February 22, 2023 21:40
@AMoo-Miki
Copy link
Collaborator

Temporarily blocking this from merging. If release is delayed, we will merge in, else it will go n 2.6.1 or 2.7.0.

@joshuarrrr
Copy link
Member

OK - I think we also need to pull it from the release notes then #3484

@joshuarrrr joshuarrrr added v2.7.0 and removed v2.6.0 labels Feb 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3486 (d67e1fd) into 2.6 (82c45c1) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.6    #3486   +/-   ##
=======================================
  Coverage   66.44%   66.45%           
=======================================
  Files        3205     3205           
  Lines       61567    61567           
  Branches     9497     9497           
=======================================
+ Hits        40911    40915    +4     
+ Misses      18384    18382    -2     
+ Partials     2272     2270    -2     
Flag Coverage Δ
Linux 66.40% <ø> (+<0.01%) ⬆️
Windows 66.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/setup_node_env/node_version_validator.js 51.94% <0.00%> (-2.60%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 65.77% <0.00%> (+0.88%) ⬆️
packages/osd-optimizer/src/node/cache.ts 53.94% <0.00%> (+2.63%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr mentioned this pull request Feb 23, 2023
8 tasks
@AMoo-Miki AMoo-Miki marked this pull request as ready for review March 1, 2023 17:31
@joshuarrrr joshuarrrr added the not in release PRs backported to already shipped releases with no future release planned label Mar 7, 2023
@ashwin-pc ashwin-pc merged commit 80c7abb into 2.6 Mar 7, 2023
@joshuarrrr joshuarrrr removed the v2.7.0 label Mar 7, 2023
@github-actions github-actions bot deleted the backport/backport-3479-to-2.6 branch March 7, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports not in release PRs backported to already shipped releases with no future release planned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants