[BUG][TSVB] Fix serial diff agg link

[kavilla]

Description

Doc link was invalid and causing an undefined error. This prevented the UI from mounting properly.

Issues Resolved

• [BUG] unable to create "serial difference" in TSVB visualization #3498
• [BUG] TSVB fails to load in "edit" mode after upgrading from Opensearch 1.2 to 1.3 #3327

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov-commenter]

Codecov Report

Merging #3503 (20cb157) into main (02e0bc1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3503      +/-   ##
==========================================
- Coverage   66.45%   66.45%   -0.01%     
==========================================
  Files        3205     3205              
  Lines       61562    61562              
  Branches     9497     9497              
==========================================
- Hits        40912    40910       -2     
- Misses      18353    18380      +27     
+ Partials     2297     2272      -25     

Flag	Coverage Δ
Linux	66.39% <0.00%> (-0.01%)	⬇️
Windows	66.40% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../public/application/components/aggs/serial_diff.js	18.18% <0.00%> (ø)
...ic/application/models/sense_editor/sense_editor.ts	64.88% <0.00%> (-0.89%)	⬇️
packages/osd-optimizer/src/node/cache.ts	51.31% <0.00%> (ø)
packages/osd-test/src/junit_report_path.ts	62.50% <0.00%> (ø)
packages/osd-optimizer/src/run_optimizer.ts	23.52% <0.00%> (ø)
packages/osd-optimizer/src/log_optimizer_state.ts	4.54% <0.00%> (ø)
...ckages/osd-optimizer/src/report_optimizer_stats.ts	21.42% <0.00%> (ø)
...s/osd-optimizer/src/node/node_auto_tranpilation.ts	83.67% <0.00%> (ø)
...est_runner/lib/docker_servers/container_running.ts	11.76% <0.00%> (ø)
...unner/lib/docker_servers/docker_servers_service.ts	28.98% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ashwin-pc]

@kavilla can you provide a little more info about why this is undefined? I see many instances around OSD where doclinks is referred to directly. Want to know if we know the reason this is happening ad if we should update the other instances as well.

e.g.

1. OpenSearch-Dashboards/src/plugins/advanced_settings/public/management_app/mount_management_section.tsx

   Line 82 in f5ee06d

   dockLinks={docLinks.links}

2. OpenSearch-Dashboards/src/plugins/dashboard/public/application/help_menu/help_menu_util.ts

   Line 45 in f5ee06d

   href: `${docLinks.links.opensearchDashboards.introduction}`,

And these are just a few. In all these instances doclinks is assumed to be always defined. At least based on the type signature.

[kavilla]

@kavilla can you provide a little more info about why this is undefined?

I think it was a "typo" because the variable was split. But the original code basically went in like:

useOpenSearchDashboards().services.docLinks.services.links.opensearch.aggregations.pipeline.serial_diff

instead of:

useOpenSearchDashboards().services.docLinks?.links.opensearch.aggregations.pipeline.serial_diff

Consolidating coding style to match the other instances on how the doc link was referenced in other files.

[joshuarrrr]

@kavilla can you provide a little more info about why this is undefined? I see many instances around OSD where doclinks is referred to directly. Want to know if we know the reason this is happening ad if we should update the other instances as well.

e.g.

1. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/f5ee06d99c7f3dcc9110468125b8e94e0daf6cc1/src/plugins/advanced_settings/public/management_app/mount_management_section.tsx#L82

2. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/f5ee06d99c7f3dcc9110468125b8e94e0daf6cc1/src/plugins/dashboard/public/application/help_menu/help_menu_util.ts#L45

And these are just a few. In all these instances doclinks is assumed to be always defined. At least based on the type signature.

@ashwin-pc That's what I created this issue for: #3392

@kavilla does 3392 need any additional context from this fix?