Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] [Dev] enable opensearch snapshot for Darwin #3583

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 81a5fad from #3537.

Enable the downloading of Darwin for running the command
`yarn opensearch snapshot`.

Darwin is not officially supported but snapshots are being
built here:
https://build.ci.opensearch.org/job/distribution-build-opensearch/

Issue resolved:
#2944

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 81a5fad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Mar 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3583 (eb7ffa1) into 1.x (3a51afd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              1.x    #3583      +/-   ##
==========================================
+ Coverage   67.45%   67.49%   +0.03%     
==========================================
  Files        3044     3044              
  Lines       58696    58697       +1     
  Branches     8902     8902              
==========================================
+ Hits        39593    39616      +23     
+ Misses      16951    16932      -19     
+ Partials     2152     2149       -3     
Flag Coverage Δ
Linux 67.45% <100.00%> (-0.01%) ⬇️
Windows 67.44% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dev/build/tasks/patch_native_modules_task.ts 86.20% <ø> (ø)
packages/osd-opensearch/src/artifact.js 49.68% <100.00%> (+0.31%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr added autocut Skip the changelog verification check on backports and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Mar 10, 2023
@joshuarrrr
Copy link
Member

skipping failed whitesource check

@joshuarrrr joshuarrrr merged commit 974889a into 1.x Mar 10, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-3537-to-1.x branch March 10, 2023 18:50
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 10, 2023
Enable the downloading of Darwin for running the command
`yarn opensearch snapshot`.

Darwin is not officially supported but snapshots are being
built here:
https://build.ci.opensearch.org/job/distribution-build-opensearch/

Issue resolved:
#2944

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 81a5fad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 974889a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr added a commit that referenced this pull request Mar 10, 2023
…Darwin (#3591)

* [Dev] enable `opensearch snapshot` for Darwin (#3537) (#3583)

Enable the downloading of Darwin for running the command
`yarn opensearch snapshot`.

Darwin is not officially supported but snapshots are being
built here:
https://build.ci.opensearch.org/job/distribution-build-opensearch/

Issue resolved:
#2944

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 81a5fad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 974889a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update changelog

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports backport 1.3 v1.3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants