[Vega] Add Filter custom label for opensearchDashboardsAddFilter

[aswath86]

Description

Vega 'opensearchDashboardsAddFilter' allows to add OpenSearch Query DSL and index. The implementation buildQueryFilter takes in third parameter to set a custom label in 'Add Filter'. At the moment, opensearchDashboardsAddFilter can only take query and index parameters.

Issues Resolved

This PR adds in the third 'alias' parameter to set the custom label from Vega

buildQueryFilter = (query: QueryStringFilter['query'], index: string, alias: string)

Below image is self explanatory. The first filter in the image is without custom label (ugly, in my opinion), and the second filter is with custom label set in Vega.

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov-commenter]

Codecov Report

Merging #3640 (8dbdf1b) into main (de06344) will increase coverage by 0.00%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3640   +/-   ##
=======================================
  Coverage   66.45%   66.46%           
=======================================
  Files        3208     3209    +1     
  Lines       61593    61610   +17     
  Branches     9502     9505    +3     
=======================================
+ Hits        40932    40947   +15     
- Misses      18384    18385    +1     
- Partials     2277     2278    +1     

Flag	Coverage Δ
Linux	66.40% <0.00%> (+<0.01%)	⬆️
Windows	66.41% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/vis_type_vega/public/vega_view/vega_base_view.js	56.09% <0.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[joshuarrrr]

Love to see this addition. Thanks @aswath86 !

[joshuarrrr]

Ideally, we'd love a functional or unit test for this, but there are no existing unit tests for vega_base_view.js. And while we could add a test case to

OpenSearch-Dashboards/test/functional/apps/visualize/_vega_chart.ts

Lines 263 to 269 in 2de11ff

	it('should set filter by calling "opensearchDashboardsAddFilter" expression', async () => {
	await fillSpecAndGo(
	getTestSpec('opensearchDashboardsAddFilter({ query_string: { query: "response:200" }})')
	);
	expect(await filterBar.getFilterCount()).to.be(1);
	});

there's little benefit, because our testing service for the filterBar has no mechanisms for retrieving the custom label/filter alias we're now able to set: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/test/functional/services/filter_bar.ts