[CVE-2022-25758][1.x]Bump scss-tokenizer from 0.3.0 to 0.4.3 #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
force-pushed
the
1.x-bump-scss-tokenizer
branch
from
7c25828 to
1d410b3
Compare
ananzh
added
cve
joshuarrrr
reviewed
Mar 30, 2023
CHANGELOG.md
Outdated
| @@ -9,6 +9,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
|
|
|||
| ### 🛡 Security | |||
|
|
|||
| - [CVE-2022-25758]Bump scss-tokenizer from 0.3.0 to 0.4.3 ([#3727](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3727)) | |||
There was a problem hiding this comment.
🤣 If I'm wrong about whether we prefer a space or not, feel free to ignore and throw a shoe at me
Suggested change
| - [CVE-2022-25758]Bump scss-tokenizer from 0.3.0 to 0.4.3 ([#3727](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3727)) | |
| - [CVE-2022-25758] Bump scss-tokenizer from 0.3.0 to 0.4.3 ([#3727](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3727)) |
There was a problem hiding this comment.
Don't worry, we don't condone violence in the workplace.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 1.x #3727 +/- ##
=======================================
Coverage 67.49% 67.50%
=======================================
Files 3044 3044
Lines 58692 58692
Branches 8902 8902
=======================================
+ Hits 39617 39619 +2
+ Misses 16926 16925 -1
+ Partials 2149 2148 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ananzh
force-pushed
the
1.x-bump-scss-tokenizer
branch
from
1d410b3 to
8cf7d59
Compare
Issue Resolve opensearch-project#1842 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
force-pushed
the
1.x-bump-scss-tokenizer
branch
from
8cf7d59 to
2b21918
Compare
joshuarrrr
previously approved these changes
Mar 30, 2023
kavilla
previously approved these changes
Mar 30, 2023
|
All tests passed, with 2 approvals. Just need to resolve CHANGELOG conflicts before merging. |
joshuarrrr
approved these changes
Apr 5, 2023
abbyhu2000
approved these changes
Apr 5, 2023
ananzh
pushed a commit
that referenced
this pull request
Apr 5, 2023
…3789) Issue Resolve #1842 Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 5d4fdd2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scss-tokenizeris a dependency ofsass-graphand a nested dependency ofnode-sass. The latestsass-graph@v4.0.1 bumpsscss-tokenizer@^0.4.3here. This change is kicked innode-sass@7.0.3. In 1.x, we usednode-sass@4.13.1:We can’t bump node-sass 1) 3 major version upgrades which include breaking changes 2)
node-sassversion 6 already drops support for node 10. See the releases here .So could we resolve it? The sass-graph we are using is @v3.0.5, see below.
sass-graph@3.0.5uses "scss-tokenizer": "^0.3.0" here. Our target version 0.4.3 is within this range. I don’t see breaking changes here. The fix is to add a resolution to bump it.Issue Resolve
#1842
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr