[Multiple DataSource] Integrate multiple datasource with dev tool console #3754

zhongnansu · 2023-03-31T08:53:57Z

Description

[Multiple DataSource] Integrate multiple datasource with dev tool console

Update:

After #3775 fixes autocomplete issue, I updated this PR to adopt the change, autocomplete also works for datasources now

Video

Screen.Recording.2023-03-31.at.10.34.05.AM.mov

Issues Resolved

#2699
part of #3577

Check List

codecov-commenter · 2023-03-31T09:51:30Z

Codecov Report

Merging #3754 (076c04c) into main (29008fa) will decrease coverage by 0.02%.
The diff coverage is 45.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3754      +/-   ##
==========================================
- Coverage   66.43%   66.42%   -0.02%     
==========================================
  Files        3209     3209              
  Lines       61677    61685       +8     
  Branches     9521     9525       +4     
==========================================
- Hits        40978    40977       -1     
- Misses      18419    18424       +5     
- Partials     2280     2284       +4

Flag	Coverage Δ
Linux	`66.37% <45.83%> (-0.02%)`	⬇️
Windows	`66.38% <45.83%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...equest_to_opensearch/send_request_to_opensearch.ts	`70.49% <ø> (ø)`
...ugins/console/public/application/stores/request.ts	`55.00% <0.00%> (-13.75%)`	⬇️
...lugins/console/public/lib/opensearch/opensearch.ts	`75.00% <ø> (ø)`
...rver/routes/api/console/proxy/validation_config.ts	`100.00% <ø> (ø)`
.../data_source_management/public/components/utils.ts	`100.00% <ø> (ø)`
...rc/plugins/console/public/lib/mappings/mappings.js	`72.78% <37.50%> (ø)`
.../server/routes/api/console/proxy/create_handler.ts	`68.29% <40.00%> (-6.07%)`	⬇️
...ensearch/use_send_current_request_to_opensearch.ts	`68.00% <66.66%> (ø)`
...containers/editor/legacy/console_editor/editor.tsx	`55.00% <100.00%> (ø)`
...ole/server/routes/api/console/proxy/tests/mocks.ts	`90.90% <100.00%> (+2.02%)`	⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

zhongnansu · 2023-03-31T17:56:19Z

cc: @KrooshalUX for UI/UX feedback

src/plugins/console/server/routes/api/console/proxy/create_handler.ts

src/plugins/dev_tools/public/application.tsx

src/plugins/console/server/routes/api/console/proxy/tests/query_string.test.ts

KrooshalUX · 2023-04-04T23:09:44Z

LGTM from UX perspective - small nit, but it looks like the use of "tabs" means that the horizontal rule is getting truncated in order to accommodate the picker. Not blocking now, but if its an easy fix to remove the Tab, change "console" into a header, and place in a horizontal rule, that would be a nice touch.

zhongnansu · 2023-04-05T21:15:19Z

LGTM from UX perspective - small nit, but it looks like the use of "tabs" means that the horizontal rule is getting truncated in order to accommodate the picker. Not blocking now, but if its an easy fix to remove the Tab, change "console" into a header, and place in a horizontal rule, that would be a nice touch.

The tricky part is, tab is generated not by console plugin, but by dev_tool plugin. There's a chance that other plugins are relying dev_tool plugin to register themselves, which will generate another tab in dev tool page. If we change this, it will break the contract with existing plugins. I'd suggest we review the blast radius and have the change in 3.0.0 @KrooshalUX

abbyhu2000 · 2023-04-06T22:11:06Z

src/plugins/dev_tools/public/application.tsx

 const mountedTool = useRef<MountedDevToolDescriptor | null>(null);
+ const [dataSources, setDataSources] = useState<DataSourceOption[]>([]);
+ const [selectedOptions, setSelected] = useState<DataSourceOption[]>([]);


nit: setSelectedOptions?

good catch, let me fix this

abbyhu2000 · 2023-04-06T22:22:20Z

src/plugins/console/public/plugin.ts

@@ -62,7 +62,7 @@ export class ConsoleUIPlugin implements Plugin<void, void, AppSetupUIPluginDepen
 defaultMessage: 'Console',
 }),
 enableRouting: false,
- mount: async ({ element }) => {
+ mount: async ({ element, dataSourceId }) => {
 const [core] = await getStartServices();



Should we follow the format as other plugins here?

mount: async (params: AppMountParameters) => { const { element, dataSourceId } = params;

I'd rather keep it, reducing 1 more line of code~

KrooshalUX · 2023-04-06T22:38:43Z

LGTM from UX perspective - small nit, but it looks like the use of "tabs" means that the horizontal rule is getting truncated in order to accommodate the picker. Not blocking now, but if its an easy fix to remove the Tab, change "console" into a header, and place in a horizontal rule, that would be a nice touch.

The tricky part is, tab is generated not by console plugin, but by dev_tool plugin. There's a chance that other plugins are relying dev_tool plugin to register themselves, which will generate another tab in dev tool page. If we change this, it will break the contract with existing plugins. I'd suggest we review the blast radius and have the change in 3.0.0 @KrooshalUX

Gotcha, that is helpful context. I have some ideas that I can take to the feature owners for further exploration.

…sole Signed-off-by: Su <szhongna@amazon.com>

Signed-off-by: Su <szhongna@amazon.com>

zhongnansu · 2023-04-06T23:24:59Z

address the comment, CI should be good, since the change is only function naming, merging

…sole (#3754) * [Multiple DataSource] Integrate multiple datasource with dev tool console * update to support autocomplete when datasource is selected Signed-off-by: Su <szhongna@amazon.com> (cherry picked from commit a6af77d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

…sole (#3754) (#3802) * [Multiple DataSource] Integrate multiple datasource with dev tool console * update to support autocomplete when datasource is selected Signed-off-by: Su <szhongna@amazon.com> (cherry picked from commit a6af77d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…sole (opensearch-project#3754) * [Multiple DataSource] Integrate multiple datasource with dev tool console * update to support autocomplete when datasource is selected Signed-off-by: Su <szhongna@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>

zhongnansu requested a review from a team as a code owner March 31, 2023 08:53

zhongnansu added multiple datasource multiple datasource project v2.7.0 backport 2.x labels Mar 31, 2023

zhongnansu mentioned this pull request Mar 31, 2023

2.7.0 Platform Upgrades for Plugins (O11y, MDS, Geospatial,+) #3674

Closed

23 tasks

ananzh assigned kristenTian Mar 31, 2023

kristenTian reviewed Apr 4, 2023

View reviewed changes

src/plugins/console/server/routes/api/console/proxy/create_handler.ts Show resolved Hide resolved

kristenTian reviewed Apr 4, 2023

View reviewed changes

src/plugins/dev_tools/public/application.tsx Outdated Show resolved Hide resolved

kristenTian reviewed Apr 4, 2023

View reviewed changes

src/plugins/console/server/routes/api/console/proxy/tests/query_string.test.ts Outdated Show resolved Hide resolved

kristenTian reviewed Apr 4, 2023

View reviewed changes

src/plugins/console/server/routes/api/console/proxy/tests/query_string.test.ts Outdated Show resolved Hide resolved

zhongnansu requested a review from KrooshalUX April 4, 2023 23:17

kristenTian previously approved these changes Apr 5, 2023

View reviewed changes

zhongnansu dismissed kristenTian’s stale review via f059d32 April 5, 2023 00:07

kristenTian previously approved these changes Apr 5, 2023

View reviewed changes

joshuarrrr self-assigned this Apr 5, 2023

zhongnansu assigned abbyhu2000 Apr 5, 2023

zhongnansu linked an issue Apr 5, 2023 that may be closed by this pull request

[MD]Multi data source integration with Dev tool #2699

Closed

zhongnansu added the console label Apr 6, 2023

zhongnansu dismissed kristenTian’s stale review via 076c04c April 6, 2023 20:04

zhongnansu force-pushed the md-dev-tool-integ branch from f059d32 to 076c04c Compare April 6, 2023 20:04

zhongnansu requested review from kristenTian and abbyhu2000 April 6, 2023 20:07

kristenTian previously approved these changes Apr 6, 2023

View reviewed changes

abbyhu2000 reviewed Apr 6, 2023

View reviewed changes

abbyhu2000 previously approved these changes Apr 6, 2023

View reviewed changes

zhongnansu added 3 commits April 6, 2023 16:04

[Multiple DataSource] Integrate multiple datasource with dev tool con…

ccca726

…sole Signed-off-by: Su <szhongna@amazon.com>

address comment

55bd6bc

Signed-off-by: Su <szhongna@amazon.com>

update to support autocomplete when datasource is selected

2fbbaa0

Signed-off-by: Su <szhongna@amazon.com>

zhongnansu dismissed stale reviews from abbyhu2000 and kristenTian via 2fbbaa0 April 6, 2023 23:06

zhongnansu force-pushed the md-dev-tool-integ branch from 076c04c to 2fbbaa0 Compare April 6, 2023 23:06

zhongnansu requested review from kristenTian and abbyhu2000 April 6, 2023 23:07

kristenTian approved these changes Apr 6, 2023

View reviewed changes

abbyhu2000 approved these changes Apr 6, 2023

View reviewed changes

zhongnansu merged commit a6af77d into opensearch-project:main Apr 6, 2023

opensearch-trigger-bot bot mentioned this pull request Apr 6, 2023

[Backport 2.x] [Multiple DataSource] Integrate multiple datasource with dev tool console #3802

Merged

zhongnansu mentioned this pull request Apr 7, 2023

[Console][Multiple Datasource]Fine tuned dev tool datasource selector UI #3806

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Multiple DataSource] Integrate multiple datasource with dev tool console #3754

[Multiple DataSource] Integrate multiple datasource with dev tool console #3754

zhongnansu commented Mar 31, 2023 •

edited

Loading

codecov-commenter commented Mar 31, 2023 •

edited

Loading

zhongnansu commented Mar 31, 2023

KrooshalUX commented Apr 4, 2023

zhongnansu commented Apr 5, 2023

abbyhu2000 Apr 6, 2023

zhongnansu Apr 6, 2023

abbyhu2000 Apr 6, 2023

zhongnansu Apr 6, 2023

KrooshalUX commented Apr 6, 2023

zhongnansu commented Apr 6, 2023

[Multiple DataSource] Integrate multiple datasource with dev tool console #3754

[Multiple DataSource] Integrate multiple datasource with dev tool console #3754

Conversation

zhongnansu commented Mar 31, 2023 • edited Loading

Description

Update:

Issues Resolved

Check List

codecov-commenter commented Mar 31, 2023 • edited Loading

Codecov Report

zhongnansu commented Mar 31, 2023

KrooshalUX commented Apr 4, 2023

zhongnansu commented Apr 5, 2023

abbyhu2000 Apr 6, 2023

Choose a reason for hiding this comment

zhongnansu Apr 6, 2023

Choose a reason for hiding this comment

abbyhu2000 Apr 6, 2023

Choose a reason for hiding this comment

zhongnansu Apr 6, 2023

Choose a reason for hiding this comment

KrooshalUX commented Apr 6, 2023

zhongnansu commented Apr 6, 2023

zhongnansu commented Mar 31, 2023 •

edited

Loading

codecov-commenter commented Mar 31, 2023 •

edited

Loading