-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update folder names for pre-installed plugins to kebab-case #385
Update folder names for pre-installed plugins to kebab-case #385
Conversation
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
✅ DCO Check Passed 0d05b77 |
Signed-off-by: Vacha Shah <vachshah@amazon.com>
✅ DCO Check Passed d8f7f67 |
@VachaShah Thanks for the PR, I see 5k files changes, are these expected? |
Also, if we decide to go with this approach, we will need to break the the PRs in smaller one, else Git will not be able to carry forward the history. IMO we should do this change as part of 2.0. |
@mihirsoni Yes, there are so many files since the rename is for all the pre-installed plugins folders inside |
I tried to break the PR for each with a bunch of plugins in each but there are files which would be common in each of them, making it harder to break down. I thought it would be easier if the rename is just in one PR in terms of commit history, LMK what you think. |
This is a bunch of renaming and seems harmless enough, LGTM. |
@mihirsoni I wonder whether it's worth putting this in 1.0 to make it easier for upgrades 1.0 -> 1.x. |
Hi @dblock this is my concerns
|
@mihirsoni I will work on breaking down this PR into smaller ones, mostly one for each plugin. I have also updated the description for testing as well. |
Can this PR be closed? |
Yes I have created the smaller PRs for all the plugins, closing this PR now. |
Description
This PR updates the folder names for pre-installed plugins in
src/plugins
to kebab-case to maintain consistency as described in Issue #322.Testing
The following commands succeeded:
yarn test:jest
TEST_OPENSEARCH_FROM=/path/to/extracted/build/artifact yarn test:jest_integration
Issues Resolved
Part 2 of #322.
Check List