Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming embeddable, expressions plugin folder to kebab-case #399

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@
* GitHub history for details.
*/

export * from '../../../plugins/embeddable/public/lib/test_samples';
export * from '../../../plugins/embeddable/public/lib/test-samples';
2 changes: 1 addition & 1 deletion src/plugins/embeddable/public/index.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@import './variables';
@import './lib/panel/index';
@import './lib/panel/panel_header/index';
@import './lib/panel/panel-header/index';
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import { EditPanelAction } from './edit_panel_action';
import { Embeddable, EmbeddableInput, SavedObjectEmbeddableInput } from '../embeddables';
import { ViewMode } from '../types';
import { ContactCardEmbeddable } from '../test_samples';
import { ContactCardEmbeddable } from '../test-samples';
import { embeddablePluginMock } from '../../mocks';
import { applicationServiceMock } from '../../../../../core/public/mocks';
import { of } from 'rxjs';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@
import React from 'react';
import { nextTick } from 'test_utils/enzyme_helpers';
import { EmbeddableChildPanel } from './embeddable_child_panel';
import { CONTACT_CARD_EMBEDDABLE } from '../test_samples/embeddables/contact_card/contact_card_embeddable_factory';
import { SlowContactCardEmbeddableFactory } from '../test_samples/embeddables/contact_card/slow_contact_card_embeddable_factory';
import { HelloWorldContainer } from '../test_samples/embeddables/hello_world_container';
import { CONTACT_CARD_EMBEDDABLE } from '../test-samples/embeddables/contact-card/contact_card_embeddable_factory';
import { SlowContactCardEmbeddableFactory } from '../test-samples/embeddables/contact-card/slow_contact_card_embeddable_factory';
import { HelloWorldContainer } from '../test-samples/embeddables/hello_world_container';
import {
ContactCardEmbeddableInput,
ContactCardEmbeddableOutput,
ContactCardEmbeddable,
} from '../test_samples/embeddables/contact_card/contact_card_embeddable';
} from '../test-samples/embeddables/contact-card/contact_card_embeddable';
import { inspectorPluginMock } from '../../../../inspector/public/mocks';
import { mount } from 'enzyme';
import { embeddablePluginMock, createEmbeddablePanelMock } from '../../mocks';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ import { skip } from 'rxjs/operators';
import { Embeddable } from './embeddable';
import { EmbeddableOutput, EmbeddableInput } from './i_embeddable';
import { ViewMode } from '../types';
import { ContactCardEmbeddable } from '../test_samples/embeddables/contact_card/contact_card_embeddable';
import { FilterableEmbeddable } from '../test_samples/embeddables/filterable_embeddable';
import { ContactCardEmbeddable } from '../test-samples/embeddables/contact-card/contact_card_embeddable';
import { FilterableEmbeddable } from '../test-samples/embeddables/filterable_embeddable';

class TestClass {
constructor() {}
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/embeddable/public/lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ export * from './actions';
export * from './triggers';
export * from './containers';
export * from './panel';
export * from './state_transfer';
export * from './reference_or_value_embeddable';
export * from './state-transfer';
export * from './reference-or-value-embeddable';
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,17 @@ import { Action, UiActionsStart, ActionType } from '../../../../ui_actions/publi
import { Trigger, ViewMode } from '../types';
import { isErrorEmbeddable } from '../embeddables';
import { EmbeddablePanel } from './embeddable_panel';
import { createEditModeAction } from '../test_samples/actions';
import { createEditModeAction } from '../test-samples/actions';
import {
ContactCardEmbeddableFactory,
CONTACT_CARD_EMBEDDABLE,
} from '../test_samples/embeddables/contact_card/contact_card_embeddable_factory';
import { HelloWorldContainer } from '../test_samples/embeddables/hello_world_container';
} from '../test-samples/embeddables/contact-card/contact_card_embeddable_factory';
import { HelloWorldContainer } from '../test-samples/embeddables/hello_world_container';
import {
ContactCardEmbeddable,
ContactCardEmbeddableInput,
ContactCardEmbeddableOutput,
} from '../test_samples/embeddables/contact_card/contact_card_embeddable';
} from '../test-samples/embeddables/contact-card/contact_card_embeddable';
import { inspectorPluginMock } from '../../../../inspector/public/mocks';
import { EuiBadge } from '@elastic/eui';
import { embeddablePluginMock } from '../../mocks';
Expand Down
12 changes: 6 additions & 6 deletions src/plugins/embeddable/public/lib/panel/embeddable_panel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@ import {
} from '../embeddables/i_embeddable';
import { ViewMode } from '../types';

import { RemovePanelAction } from './panel_header/panel_actions';
import { AddPanelAction } from './panel_header/panel_actions/add_panel/add_panel_action';
import { CustomizePanelTitleAction } from './panel_header/panel_actions/customize_title/customize_panel_action';
import { PanelHeader } from './panel_header/panel_header';
import { InspectPanelAction } from './panel_header/panel_actions/inspect_panel_action';
import { RemovePanelAction } from './panel-header/panel-actions';
import { AddPanelAction } from './panel-header/panel-actions/add-panel/add_panel_action';
import { CustomizePanelTitleAction } from './panel-header/panel-actions/customize-title/customize_panel_action';
import { PanelHeader } from './panel-header/panel_header';
import { InspectPanelAction } from './panel-header/panel-actions/inspect_panel_action';
import { EditPanelAction } from '../actions';
import { CustomizePanelModal } from './panel_header/panel_actions/customize_title/customize_panel_modal';
import { CustomizePanelModal } from './panel-header/panel-actions/customize-title/customize_panel_modal';
import { EmbeddableStart } from '../../plugin';
import { EmbeddableErrorLabel } from './embeddable_error_label';
import { EmbeddableStateTransfer, ErrorEmbeddable } from '..';
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/embeddable/public/lib/panel/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@
*/

export * from './embeddable_panel';
export * from './panel_header';
export * from './panel-header';
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@
* GitHub history for details.
*/

export * from './panel_actions';
export * from './panel-actions';
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ import {
FILTERABLE_EMBEDDABLE,
FilterableEmbeddable,
FilterableEmbeddableInput,
} from '../../../../test_samples/embeddables/filterable_embeddable';
import { FilterableEmbeddableFactory } from '../../../../test_samples/embeddables/filterable_embeddable_factory';
import { FilterableContainer } from '../../../../test_samples/embeddables/filterable_container';
} from '../../../../test-samples/embeddables/filterable_embeddable';
import { FilterableEmbeddableFactory } from '../../../../test-samples/embeddables/filterable_embeddable_factory';
import { FilterableContainer } from '../../../../test-samples/embeddables/filterable_container';
import { coreMock } from '../../../../../../../../core/public/mocks';
import { ContactCardEmbeddable } from '../../../../test_samples';
import { ContactCardEmbeddable } from '../../../../test-samples';
import { opensearchFilters, Filter } from '../../../../../../../../plugins/data/public';
import { EmbeddableStart } from '../../../../../plugin';
import { embeddablePluginMock } from '../../../../../mocks';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ import { AddPanelFlyout } from './add_panel_flyout';
import {
ContactCardEmbeddableFactory,
CONTACT_CARD_EMBEDDABLE,
} from '../../../../test_samples/embeddables/contact_card/contact_card_embeddable_factory';
import { HelloWorldContainer } from '../../../../test_samples/embeddables/hello_world_container';
import { ContactCardEmbeddable } from '../../../../test_samples/embeddables/contact_card/contact_card_embeddable';
} from '../../../../test-samples/embeddables/contact-card/contact_card_embeddable_factory';
import { HelloWorldContainer } from '../../../../test-samples/embeddables/hello_world_container';
import { ContactCardEmbeddable } from '../../../../test-samples/embeddables/contact-card/contact_card_embeddable';
import { ContainerInput } from '../../../../containers';
import { mountWithIntl as mount } from 'test_utils/enzyme_helpers';
import { ReactWrapper } from 'enzyme';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ import {
ContactCardEmbeddable,
ContactCardEmbeddableInput,
ContactCardEmbeddableOutput,
} from '../../../../test_samples/embeddables/contact_card/contact_card_embeddable';
} from '../../../../test-samples/embeddables/contact-card/contact_card_embeddable';
import {
CONTACT_CARD_EMBEDDABLE,
ContactCardEmbeddableFactory,
} from '../../../../test_samples/embeddables/contact_card/contact_card_embeddable_factory';
import { HelloWorldContainer } from '../../../../test_samples/embeddables/hello_world_container';
} from '../../../../test-samples/embeddables/contact-card/contact_card_embeddable_factory';
import { HelloWorldContainer } from '../../../../test-samples/embeddables/hello_world_container';
import { embeddablePluginMock } from '../../../../../mocks';

let container: Container;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@
*/

export * from './inspect_panel_action';
export * from './add_panel';
export * from './add-panel';
export * from './remove_panel_action';
export * from './customize_title';
export * from './customize-title';
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import {
FilterableEmbeddableInput,
FilterableEmbeddable,
ContactCardEmbeddable,
} from '../../../test_samples';
} from '../../../test-samples';
import { inspectorPluginMock } from '../../../../../../../plugins/inspector/public/mocks';
import { EmbeddableOutput, isErrorEmbeddable, ErrorEmbeddable } from '../../../embeddables';
import { of } from '../../../../tests/helpers';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ import {
FILTERABLE_EMBEDDABLE,
FilterableEmbeddable,
FilterableEmbeddableInput,
} from '../../../test_samples/embeddables/filterable_embeddable';
import { FilterableEmbeddableFactory } from '../../../test_samples/embeddables/filterable_embeddable_factory';
import { FilterableContainer } from '../../../test_samples/embeddables/filterable_container';
} from '../../../test-samples/embeddables/filterable_embeddable';
import { FilterableEmbeddableFactory } from '../../../test-samples/embeddables/filterable_embeddable_factory';
import { FilterableContainer } from '../../../test-samples/embeddables/filterable_container';
import { ViewMode } from '../../../types';
import { ContactCardEmbeddable } from '../../../test_samples/embeddables/contact_card/contact_card_embeddable';
import { ContactCardEmbeddable } from '../../../test-samples/embeddables/contact-card/contact_card_embeddable';
import { opensearchFilters, Filter } from '../../../../../../../plugins/data/public';
import { embeddablePluginMock } from '../../../../mocks';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* GitHub history for details.
*/

export * from './contact_card';
export * from './contact-card';
export * from './empty_embeddable';
export * from './filterable_container';
export * from './filterable_container_factory';
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/embeddable/public/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ import {
EmbeddablePanel,
} from './lib';
import { EmbeddableFactoryDefinition } from './lib/embeddables/embeddable_factory_definition';
import { EmbeddableStateTransfer } from './lib/state_transfer';
import { EmbeddableStateTransfer } from './lib/state-transfer';
import {
extractBaseEmbeddableInput,
injectBaseEmbeddableInput,
Expand Down
14 changes: 7 additions & 7 deletions src/plugins/embeddable/public/tests/container.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,25 +43,25 @@ import {
FilterableEmbeddableInput,
FilterableEmbeddable,
FILTERABLE_EMBEDDABLE,
} from '../lib/test_samples/embeddables/filterable_embeddable';
} from '../lib/test-samples/embeddables/filterable_embeddable';
import { ERROR_EMBEDDABLE_TYPE } from '../lib/embeddables/error_embeddable';
import { FilterableEmbeddableFactory } from '../lib/test_samples/embeddables/filterable_embeddable_factory';
import { CONTACT_CARD_EMBEDDABLE } from '../lib/test_samples/embeddables/contact_card/contact_card_embeddable_factory';
import { SlowContactCardEmbeddableFactory } from '../lib/test_samples/embeddables/contact_card/slow_contact_card_embeddable_factory';
import { FilterableEmbeddableFactory } from '../lib/test-samples/embeddables/filterable_embeddable_factory';
import { CONTACT_CARD_EMBEDDABLE } from '../lib/test-samples/embeddables/contact-card/contact_card_embeddable_factory';
import { SlowContactCardEmbeddableFactory } from '../lib/test-samples/embeddables/contact-card/slow_contact_card_embeddable_factory';
import {
HELLO_WORLD_EMBEDDABLE,
HelloWorldEmbeddableFactoryDefinition,
} from '../../../../../examples/embeddable_examples/public';
import { HelloWorldContainer } from '../lib/test_samples/embeddables/hello_world_container';
import { HelloWorldContainer } from '../lib/test-samples/embeddables/hello_world_container';
import {
ContactCardEmbeddableInput,
ContactCardEmbeddableOutput,
ContactCardEmbeddable,
} from '../lib/test_samples/embeddables/contact_card/contact_card_embeddable';
} from '../lib/test-samples/embeddables/contact-card/contact_card_embeddable';
import {
FilterableContainer,
FilterableContainerInput,
} from '../lib/test_samples/embeddables/filterable_container';
} from '../lib/test-samples/embeddables/filterable_container';
import { coreMock } from '../../../../core/public/mocks';
import { testPlugin } from './test_plugin';
import { of } from './helpers';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ import {
ContactCardEmbeddable,
ContactCardEmbeddableInput,
ContactCardEmbeddableOutput,
} from '../lib/test_samples/embeddables/contact_card/contact_card_embeddable';
} from '../lib/test-samples/embeddables/contact-card/contact_card_embeddable';
import {
CONTACT_CARD_EMBEDDABLE,
ContactCardEmbeddableFactory,
} from '../lib/test_samples/embeddables/contact_card/contact_card_embeddable_factory';
import { HelloWorldContainer } from '../lib/test_samples/embeddables/hello_world_container';
} from '../lib/test-samples/embeddables/contact-card/contact_card_embeddable_factory';
import { HelloWorldContainer } from '../lib/test-samples/embeddables/hello_world_container';
import { coreMock } from '../../../../core/public/mocks';
import { testPlugin } from './test_plugin';
import { CustomizePanelModal } from '../lib/panel/panel_header/panel_actions/customize_title/customize_panel_modal';
import { CustomizePanelModal } from '../lib/panel/panel-header/panel-actions/customize-title/customize_panel_modal';
import { EmbeddableStart } from '../plugin';
import { createEmbeddablePanelMock } from '../mocks';
import { mountWithIntl } from '../../../../test_utils/public/enzyme_helpers';
Expand Down
12 changes: 6 additions & 6 deletions src/plugins/embeddable/public/tests/explicit_input.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,17 @@ import { testPlugin } from './test_plugin';
import {
FILTERABLE_EMBEDDABLE,
FilterableEmbeddableInput,
} from '../lib/test_samples/embeddables/filterable_embeddable';
import { FilterableEmbeddableFactory } from '../lib/test_samples/embeddables/filterable_embeddable_factory';
import { CONTACT_CARD_EMBEDDABLE } from '../lib/test_samples/embeddables/contact_card/contact_card_embeddable_factory';
import { SlowContactCardEmbeddableFactory } from '../lib/test_samples/embeddables/contact_card/slow_contact_card_embeddable_factory';
} from '../lib/test-samples/embeddables/filterable_embeddable';
import { FilterableEmbeddableFactory } from '../lib/test-samples/embeddables/filterable_embeddable_factory';
import { CONTACT_CARD_EMBEDDABLE } from '../lib/test-samples/embeddables/contact-card/contact_card_embeddable_factory';
import { SlowContactCardEmbeddableFactory } from '../lib/test-samples/embeddables/contact-card/slow_contact_card_embeddable_factory';
import {
HELLO_WORLD_EMBEDDABLE,
HelloWorldEmbeddableFactoryDefinition,
} from '../../../../../examples/embeddable_examples/public';
import { FilterableContainer } from '../lib/test_samples/embeddables/filterable_container';
import { FilterableContainer } from '../lib/test-samples/embeddables/filterable_container';
import { isErrorEmbeddable } from '../lib';
import { HelloWorldContainer } from '../lib/test_samples/embeddables/hello_world_container';
import { HelloWorldContainer } from '../lib/test-samples/embeddables/hello_world_container';
import { coreMock } from '../../../../core/public/mocks';
import { opensearchFilters, Filter } from '../../../../plugins/data/public';
import { createEmbeddablePanelMock } from '../mocks';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
*/

import { testPlugin } from './test_plugin';
import { FilterableContainerFactory } from '../lib/test_samples/embeddables/filterable_container_factory';
import { ContactCardEmbeddableFactory } from '../lib/test_samples/embeddables/contact_card/contact_card_embeddable_factory';
import { FilterableContainerFactory } from '../lib/test-samples/embeddables/filterable_container_factory';
import { ContactCardEmbeddableFactory } from '../lib/test-samples/embeddables/contact-card/contact_card_embeddable_factory';

test('exports getEmbeddableFactories() function', () => {
const { doStart } = testPlugin();
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/expressions/common/ast/build_expression.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* GitHub history for details.
*/

import { AnyExpressionFunctionDefinition } from '../expression_functions/types';
import { AnyExpressionFunctionDefinition } from '../expression-functions/types';
import { ExpressionAstExpression, ExpressionAstFunction } from './types';
import {
buildExpressionFunction,
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/expressions/common/ast/build_function.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { ExpressionAstFunction } from './types';
import {
AnyExpressionFunctionDefinition,
ExpressionFunctionDefinition,
} from '../expression_functions/types';
} from '../expression-functions/types';
import {
buildExpression,
ExpressionAstExpressionBuilder,
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/expressions/common/ast/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* GitHub history for details.
*/

import { ExpressionValue, ExpressionValueError } from '../expression_types';
import { ExpressionValue, ExpressionValueError } from '../expression-types';

export type ExpressionAstNode =
| ExpressionAstExpression
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/expressions/common/execution/container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import {
} from '../../../opensearch_dashboards_utils/common/state_containers';
import { ExecutorState, defaultState as executorDefaultState } from '../executor';
import { ExpressionAstExpression } from '../ast';
import { ExpressionValue } from '../expression_types';
import { ExpressionValue } from '../expression-types';

export interface ExecutionState<Output = ExpressionValue> extends ExecutorState {
ast: ExpressionAstExpression;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

import { Execution } from './execution';
import { parseExpression } from '../ast';
import { createUnitTestExecutor } from '../test_helpers';
import { createUnitTestExecutor } from '../test-helpers';

jest.useFakeTimers();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

import { Execution } from './execution';
import { parseExpression, ExpressionAstExpression } from '../ast';
import { createUnitTestExecutor } from '../test_helpers';
import { createUnitTestExecutor } from '../test-helpers';
import { ExpressionFunctionDefinition } from '../../common';
import { ExecutionContract } from './execution_contract';

Expand Down
6 changes: 3 additions & 3 deletions src/plugins/expressions/common/execution/execution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import { createError } from '../util';
import { Defer, now } from '../../../opensearch_dashboards_utils/common';
import { toPromise } from '../../../data/common/utils/abort_utils';
import { RequestAdapter, DataAdapter, Adapters } from '../../../inspector/common';
import { isExpressionValueError, ExpressionValueError } from '../expression_types/specs/error';
import { isExpressionValueError, ExpressionValueError } from '../expression-types/specs/error';
import {
ExpressionAstExpression,
ExpressionAstFunction,
Expand All @@ -47,8 +47,8 @@ import {
ExpressionAstNode,
} from '../ast';
import { ExecutionContext, DefaultInspectorAdapters } from './types';
import { getType, ExpressionValue } from '../expression_types';
import { ArgumentType, ExpressionFunction } from '../expression_functions';
import { getType, ExpressionValue } from '../expression-types';
import { ArgumentType, ExpressionFunction } from '../expression-functions';
import { getByAlias } from '../util/get_by_alias';
import { ExecutionContract } from './execution_contract';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

import { Execution } from './execution';
import { parseExpression } from '../ast';
import { createUnitTestExecutor } from '../test_helpers';
import { createUnitTestExecutor } from '../test-helpers';
import { ExecutionContract } from './execution_contract';

const createExecution = (
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/expressions/common/execution/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* GitHub history for details.
*/

import { ExpressionType } from '../expression_types';
import { ExpressionType } from '../expression-types';
import { Adapters, DataAdapter, RequestAdapter } from '../../../inspector/common';
import { TimeRange, Query, Filter } from '../../../data/common';
import { SavedObject, SavedObjectAttributes } from '../../../../core/public';
Expand Down
Loading