Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [MD]Severless Support: update data-test-subjattribute for functional tests & fix bug in edit flow #4140

Merged
merged 1 commit into from
May 26, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 574f119 from #4126.

…#4126)

Signed-off-by: Su <szhongna@amazon.com>
(cherry picked from commit 574f119)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@zhongnansu zhongnansu added multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.8.0 labels May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #4140 (9804b2d) into 2.x (1c09ca6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.x    #4140      +/-   ##
==========================================
- Coverage   66.45%   66.45%   -0.01%     
==========================================
  Files        3229     3229              
  Lines       62064    62066       +2     
  Branches     9602     9603       +1     
==========================================
  Hits        41244    41244              
- Misses      18516    18518       +2     
  Partials     2304     2304              
Flag Coverage Δ
Linux 66.39% <100.00%> (-0.01%) ⬇️
Windows 66.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/create_form/create_data_source_form.tsx 74.00% <ø> (ø)
...rce/components/edit_form/edit_data_source_form.tsx 66.99% <100.00%> (+0.32%) ⬆️

... and 3 files with indirect coverage changes

@zhongnansu
Copy link
Member

cypress failure is not related to this change. The corresponding functional tests for datasources are passed as the CI logs show here
image

@zhongnansu zhongnansu merged commit 1fb4d48 into 2.x May 26, 2023
@github-actions github-actions bot deleted the backport/backport-4126-to-2.x branch May 26, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants