Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle Node 14 and allow fallback to Node 14 #4141

Closed
wants to merge 3 commits into from
Closed

Bundle Node 14 and allow fallback to Node 14 #4141

wants to merge 3 commits into from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented May 25, 2023 •
edited
Loading

Description

Blocked by #4071

This is resolving some backward issues to build on Node 18 for this PR #4071 . The changes include:

  • getNodeVersionDownloadInfo is responsible for generating the download information for a specific version of Node.js given the version number, architecture (e.g., x64), and the operating system.
  • Node.js 14 binaries are downloaded and copied to node/fallback directory in the build path specific to a platform.
  • Check if the desired Node.js version is available and executable, and if it is not, falling back to the path where Node.js 14 is stored (the "fallback" directory).

Issues Resolved

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

AMoo-Miki and others added 2 commits May 25, 2023 20:35
@AMoo-Miki @ananzh
Bundle Node 14 as a fallback
0eb9850 
Signed-off-by: Miki <miki@amazon.com>
@ananzh
add fall back to 14 logic
fb86582 
Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh
fix tests and add CHANGELOG
a7d71bf 
Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh marked this pull request as ready for review May 25, 2023 20:58
@AMoo-Miki
Copy link
Collaborator

Superseded by #4151

@AMoo-Miki AMoo-Miki closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

Assignees

@AMoo-Miki AMoo-Miki

@kavilla kavilla

Labels
NODE 18 ⚙ v2.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ananzh @AMoo-Miki @kavilla