-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(oui): Bump OUI dependency to 1.2.0, remove breadcrumb styling #4170
Conversation
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Converting to draft until v1.2.0 is released. But we can run the CI against the release candidate. |
Signed-off-by: Josh Romero <rmerqg@amazon.com>
I opened a separate PR for the Link Checker failure: #4171 |
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Breadcrumbs probably look wonky with current changes. New breadcrumb styling went into 1.2, so the styling is most likely being applied twice. I outlined how to fix in here: opensearch-project/oui#796 (comment) |
Thanks @BSFishy for the instructions - I'll update the PR accordingly. |
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Now that the breacrumb styling is updated in OUI v1.2.0 Signed-off-by: Josh Romero <rmerqg@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #4170 +/- ##
=======================================
Coverage 66.15% 66.15%
=======================================
Files 3314 3314
Lines 63911 63910 -1
Branches 9962 9961 -1
=======================================
+ Hits 42280 42282 +2
+ Misses 19186 19185 -1
+ Partials 2445 2443 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Essentially reverting: - opensearch-project#1954 - opensearch-project#2085 Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Discussed with @KrooshalUX: Since anywhere project got bumped from 2.8 release. This PR is not required to get in and bake longer. |
Converting to draft - we'll split the OUI changes into different releases so we can pull a clean v1.1.1 with just the icon changes. |
This is ready for re-review. Discussed with @AMoo-Miki and we're ok to take some of the breadcrumb concerns in #4457 as a blocker for this in the |
@joshuarrrr Do you want to solve the conflicts? and also there are some test fails |
Closing in favor of #4621 - no need to bump to OUI 1.2, since we've already bumped |
Description
Bump OUI version - don't merge until we update from release candidate.
OUI 1.2 includes all necessary breadcrumb styling, so OpenSearch Dashboards customizations are no longer necessary. So we're also essentially reverting the changes from:
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr