Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Bundle Node 14 as a fallback for operating systems that cannot run Node 18 #4175

Merged
merged 1 commit into from
May 30, 2023
Merged

[Backport 2.x] Bundle Node 14 as a fallback for operating systems that cannot run Node 18 #4175

merged 1 commit into from
May 30, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 20c928f from #4151.

@github-actions
Bundle Node 14 as a fallback for operating systems that cannot run No…
2ac3a18 
…de 18 (#4151)

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 20c928f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #4175 (2ac3a18) into 2.x (59d5356) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              2.x    #4175   +/-   ##
=======================================
  Coverage   66.34%   66.35%           
=======================================
  Files        3229     3229           
  Lines       62078    62091   +13     
  Branches     9609     9611    +2     
=======================================
+ Hits        41188    41201   +13     
  Misses      18570    18570           
  Partials     2320     2320
Flag Coverage Δ
Linux 66.30% <100.00%> (+<0.01%) ⬆️
Windows 66.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ev/build/tasks/nodejs/download_node_builds_task.ts 100.00% <100.00%> (ø)
...dev/build/tasks/nodejs/extract_node_builds_task.ts 100.00% <100.00%> (ø)
src/dev/build/tasks/nodejs/node_download_info.ts 61.53% <100.00%> (+11.53%) ⬆️

@kavilla kavilla merged commit c453ba2 into 2.x May 30, 2023
@github-actions github-actions bot deleted the backport/backport-4151-to-2.x branch May 30, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@kavilla kavilla kavilla approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports v2.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kavilla @abbyhu2000 @joshuarrrr @AMoo-Miki