Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] add category option for context menus #4280

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport cb27336 from #4144.

* enhance grouping for context menu options

Signed-off-by: David Sinclair <david@sinclair.tech>

* change log

Signed-off-by: David Sinclair <david@sinclair.tech>

* remove type export

Signed-off-by: David Sinclair <david@sinclair.tech>

* revert border and prevent destroy options

Signed-off-by: David Sinclair <david@sinclair.tech>

* update comments for building panels

Signed-off-by: David Sinclair <dsincla@rei.com>

* build panels tests and more comments

Signed-off-by: David Sinclair <dsincla@rei.com>

* add category option for context menus

Signed-off-by: David Sinclair <dsincla@rei.com>

* changelog

Signed-off-by: David Sinclair <dsincla@rei.com>

* add order to groups

Signed-off-by: David Sinclair <dsincla@rei.com>

* documentation, shorter copyrighty, minor cleanup

Signed-off-by: David Sinclair <dsincla@rei.com>

* changelog

Signed-off-by: David Sinclair <dsincla@rei.com>

---------

Signed-off-by: David Sinclair <david@sinclair.tech>
Signed-off-by: David Sinclair <dsincla@rei.com>
Signed-off-by: Ashish Agrawal <ashish81394@gmail.com>
Co-authored-by: Ashish Agrawal <ashish81394@gmail.com>
(cherry picked from commit cb27336)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #4280 (5af27d4) into 2.x (3363c09) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##              2.x    #4280      +/-   ##
==========================================
- Coverage   66.38%   66.37%   -0.02%     
==========================================
  Files        3229     3229              
  Lines       62121    62139      +18     
  Branches     9619     9626       +7     
==========================================
+ Hits        41242    41245       +3     
- Misses      18560    18571      +11     
- Partials     2319     2323       +4     
Flag Coverage Δ
Linux 66.32% <80.00%> (+<0.01%) ⬆️
Windows 66.31% <80.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lic/context_menu/build_eui_context_menu_panels.tsx 76.00% <80.00%> (+0.39%) ⬆️

... and 3 files with indirect coverage changes

@manasvinibs manasvinibs added autocut Skip the changelog verification check on backports v2.9.0 labels Jun 13, 2023
@manasvinibs manasvinibs merged commit 473f3a4 into 2.x Jun 13, 2023
@github-actions github-actions bot deleted the backport/backport-4144-to-2.x branch June 13, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants