[Backport 1.x] Remove broken flot documentation link for Ruby API #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Remove broken documentation link for Ruby API https://apidock.com/ruby/Time/to_i is currently down for maintenance But we don't need this link anyway, because it's talking about standard methods. And we plan to deprecate flot_charts altogether: #4267 Signed-off-by: Josh Romero <rmerqg@amazon.com> * remove leftover link brackets Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit fc4e696) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian and
zhongnansu
as code owners
opensearch-trigger-bot
bot
added
the
autocut
opensearch-trigger-bot
bot
added
Skip-Changelog
| @@ -575,7 +575,7 @@ In Python you can get it with something like: | |||
| calendar.timegm(datetime_object.timetuple()) * 1000 | |||
| ``` | |||
| In Ruby you can get it using the `#to_i` method on the | |||
| [`Time`](http://apidock.com/ruby/Time/to_i) object. If you're using the | |||
| `Time` object. If you're using the | |||
There was a problem hiding this comment.
are we planning to add new link or existing link in the future?
There was a problem hiding this comment.
No - it's just because we internalized this library (including the docs) - we will never have any need to generate compatible timestamps in ruby 😁
Flyingliuhub
approved these changes
Jun 26, 2023
ananzh
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fc4e696 from #4384.