Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Chore (deps): Bump OUI to 1.1.2 to add anomoly detection icon #4418

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e33b643 from #4408.

* Chore (deps): Bump OUI to 1.1.1 to add anomoly detection icon

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* update changelog

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit e33b643)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #4418 (b638162) into 2.x (cb88211) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #4418      +/-   ##
==========================================
+ Coverage   66.42%   66.44%   +0.02%     
==========================================
  Files        3246     3246              
  Lines       62443    62443              
  Branches     9671     9671              
==========================================
+ Hits        41477    41491      +14     
+ Misses      18621    18608      -13     
+ Partials     2345     2344       -1     
Flag Coverage Δ
Linux 66.37% <ø> (+<0.01%) ⬆️
Windows 66.39% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@@ -123,7 +123,7 @@
"dependencies": {
"@aws-crypto/client-node": "^3.1.1",
"@elastic/datemath": "5.0.3",
"@elastic/eui": "npm:@opensearch-project/oui@1.1.1",
"@elastic/eui": "npm:@opensearch-project/oui@1.1.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this required for CHANGLOG change for 2.x branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to ignore change log for backport PRs, as far as I remember release manager usually do it manually before release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, by default, the autocut label will skip the changelog verification workflow check. Ideally, once we fix the changelog system, we can get rid of that hack. That's a work in progress: #4386

@ananzh ananzh merged commit fb58d2a into 2.x Jul 1, 2023
@github-actions github-actions bot deleted the backport/backport-4408-to-2.x branch July 1, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants