Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Adds toggle between legacy and new discover #4563

Merged

Conversation

ashwin-pc
Copy link
Member

Description

Adds toggle between Discover 2.0 and Legacy Discover

Issues Resolved

Screenshot

Screen.Recording.2023-07-13.at.12.05.18.AM.mov

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc added discover for discover reinvent de-angular de-angularize work data explorer Issues related to the Data Explorer project labels Jul 13, 2023
@ashwin-pc ashwin-pc changed the title Adds toggle between legacy and new discover [Data Explorer] Adds toggle between legacy and new discover Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #4563 (a1d1270) into feature/data-explorer (d4ce533) will not change coverage.
The diff coverage is 40.00%.

@@                  Coverage Diff                   @@
##           feature/data-explorer    #4563   +/-   ##
======================================================
  Coverage                  66.52%   66.52%           
======================================================
  Files                       3280     3280           
  Lines                      62700    62700           
  Branches                    9766     9766           
======================================================
  Hits                       41713    41713           
  Misses                     18619    18619           
  Partials                    2368     2368           
Flag Coverage Δ
Linux 66.47% <40.00%> (+<0.01%) ⬆️
Windows 66.47% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/discover/public/index.ts 0.00% <ø> (ø)
src/plugins/discover/public/plugin.ts 1.36% <0.00%> (ø)
.../data_explorer/public/components/app_container.tsx 33.33% <50.00%> (ø)
src/plugins/discover/common/index.ts 100.00% <100.00%> (ø)

@ananzh ananzh merged commit 6e0a855 into opensearch-project:feature/data-explorer Jul 18, 2023
27 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent distinguished-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants