Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Optimize augment-vis saved obj searching by adding arg to saved obj client #4598

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f13e4c3 from #4595.

… client (#4595)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit f13e4c3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot added enhancement New feature or request autocut Skip the changelog verification check on backports labels Jul 20, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #4598 (7c3049c) into 2.x (4e82ca8) will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##              2.x    #4598   +/-   ##
=======================================
  Coverage   66.16%   66.17%           
=======================================
  Files        3315     3315           
  Lines       63892    63891    -1     
  Branches     9961     9966    +5     
=======================================
+ Hits        42277    42278    +1     
+ Misses      19250    19248    -2     
  Partials     2365     2365           
Flag Coverage Δ
Linux_1 34.75% <40.00%> (-0.01%) ⬇️
Linux_2 55.07% <100.00%> (+<0.01%) ⬆️
Linux_3 43.22% <0.00%> (-0.01%) ⬇️
Linux_4 35.09% <50.00%> (+<0.01%) ⬆️
Windows_1 34.76% <40.00%> (-0.01%) ⬇️
Windows_2 55.03% <100.00%> (+<0.01%) ⬆️
Windows_3 43.22% <0.00%> (-0.01%) ⬇️
Windows_4 35.09% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugmenter/public/saved_augment_vis/utils/helpers.ts 7.69% <0.00%> (+1.02%) ⬆️
...enter/public/actions/saved_object_delete_action.ts 81.25% <57.14%> (+1.25%) ⬆️
.../core/public/saved_objects/saved_objects_client.ts 92.55% <100.00%> (+0.08%) ⬆️
...objects/public/saved_object/saved_object_loader.ts 81.48% <100.00%> (+0.71%) ⬆️
...nter/public/saved_augment_vis/saved_augment_vis.ts 97.50% <100.00%> (+0.06%) ⬆️
src/plugins/vis_augmenter/public/utils/utils.ts 96.36% <100.00%> (-0.19%) ⬇️

@ashwin-pc ashwin-pc merged commit 87d546b into 2.x Jul 20, 2023
72 of 75 checks passed
@github-actions github-actions bot deleted the backport/backport-4595-to-2.x branch July 20, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor autocut Skip the changelog verification check on backports enhancement New feature or request Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry vis-augmenter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants