Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Table Visualization] Replace div containers with OuiFlex components #4624

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c3ea363 from #4272.

…4272)

* replace div containers with OuiFlex

Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>

* Update test to not include removed class

Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>

* Update Changelog

Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>

* wrap table in FlexItem

Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>

---------

Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit c3ea363)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #4624 (9633d83) into 2.x (96d12ec) will decrease coverage by 0.02%.
Report is 1 commits behind head on 2.x.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.x    #4624      +/-   ##
==========================================
- Coverage   66.10%   66.08%   -0.02%     
==========================================
  Files        3315     3315              
  Lines       63896    63897       +1     
  Branches    10122    10124       +2     
==========================================
- Hits        42238    42226      -12     
- Misses      19173    19258      +85     
+ Partials     2485     2413      -72     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_3 43.08% <ø> (ø)
Linux_4 35.09% <ø> (ø)
Windows_1 34.82% <100.00%> (+0.04%) ⬆️
Windows_2 55.03% <ø> (ø)
Windows_3 43.08% <ø> (ø)
Windows_4 35.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pe_table/public/components/table_vis_component.tsx 100.00% <ø> (ø)
...vis_type_table/public/components/table_vis_app.tsx 100.00% <100.00%> (ø)
...le/public/components/table_vis_component_group.tsx 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

@ananzh ananzh self-requested a review July 27, 2023 16:15
@joshuarrrr joshuarrrr merged commit 26dd7a4 into 2.x Aug 4, 2023
50 of 51 checks passed
@joshuarrrr joshuarrrr deleted the backport/backport-4272-to-2.x branch August 4, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports repeat-contributor v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants