Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] Reduce the amount of comments in compiled CSS and bundled CSS-in-JS #4681

Merged

Conversation

AMoo-Miki
Copy link
Collaborator

Backport 4bc1f55 from #4648

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4681 (b91efab) into 2.x (ceaaeb1) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b91efab differs from pull request most recent head 9bfa27d. Consider uploading reports for the commit 9bfa27d to get more accurate results

@@           Coverage Diff           @@
##              2.x    #4681   +/-   ##
=======================================
  Coverage   66.11%   66.11%           
=======================================
  Files        3315     3315           
  Lines       63892    63892           
  Branches    10123    10123           
=======================================
+ Hits        42239    42241    +2     
+ Misses      19168    19167    -1     
+ Partials     2485     2484    -1     
Flag Coverage Δ
Linux_1 34.77% <ø> (ø)
Linux_2 55.07% <ø> (ø)
Linux_3 43.05% <ø> (+<0.01%) ⬆️
Linux_4 35.10% <ø> (ø)
Windows_1 34.78% <ø> (ø)
Windows_2 55.03% <ø> (ø)
Windows_3 43.05% <ø> (ø)
Windows_4 35.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@joshuarrrr
Copy link
Member

@AMoo-Miki Can you update the PR and resolve conflicts?

Signed-off-by: Miki <miki@amazon.com>

(cherry picked from commit 4bc1f55)
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki AMoo-Miki force-pushed the backport/backport-4648-to-2.x branch from b91efab to 9bfa27d Compare August 11, 2023 19:12
@BSFishy
Copy link
Contributor

BSFishy commented Aug 14, 2023

@AMoo-Miki whitesource is detecting a new cve, is it a new issue?

Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is 2.x; expected.

@joshuarrrr joshuarrrr merged commit e0e6617 into opensearch-project:2.x Aug 14, 2023
50 of 51 checks passed
@ashwin-pc ashwin-pc changed the title [Backport 2.x] Reduce the amount of comments in compiled CSS [Manual Backport 2.x] Reduce the amount of comments in compiled CSS and bundled CSS-in-JS Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants