Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Force semver resolution to 7.5.3 #4686

Conversation

joshuarrrr
Copy link
Member

Description

Follow-up to complete the intended outcome of #4437

While that PR resolved all compatible ranges of the semver package, there were still vulnerable versions defined in the yarn.lock file.

Issues Resolved

#4370

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@joshuarrrr joshuarrrr changed the base branch from main to 1.3 August 4, 2023 23:11
@joshuarrrr joshuarrrr changed the title Security/force semver resolution [1.3] Force semver resolution to 7.5.3 Aug 4, 2023
fixes opensearch-project#4370

Signed-off-by: Josh Romero <rmerqg@amazon.com>
@joshuarrrr joshuarrrr force-pushed the security/force-semver-resolution branch from 27cb7b1 to a2fb54a Compare August 4, 2023 23:16
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4686 (a2fb54a) into 1.3 (b0b8fc8) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              1.3    #4686      +/-   ##
==========================================
- Coverage   67.50%   67.50%   -0.01%     
==========================================
  Files        3044     3044              
  Lines       58692    58692              
  Branches     8902     8902              
==========================================
- Hits        39621    39619       -2     
- Misses      16923    16925       +2     
  Partials     2148     2148              
Flag Coverage Δ
Linux 67.46% <ø> (ø)
Windows 67.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@joshuarrrr joshuarrrr added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 5, 2023
@joshuarrrr
Copy link
Member Author

Changelog entry already exists for previous PR.

@joshuarrrr joshuarrrr merged commit 6f8dd76 into opensearch-project:1.3 Aug 7, 2023
@joshuarrrr joshuarrrr deleted the security/force-semver-resolution branch August 7, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v1.3.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants