Fix functional tests for legacy discover plugin #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbyhu2000
added
de-angular
abbyhu2000
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX and
Flyingliuhub
as code owners
Codecov Report
@@ Coverage Diff @@
## feature/data-explorer #4687 +/- ##
=========================================================
- Coverage 66.50% 66.32% -0.19%
=========================================================
Files 3289 3380 +91
Lines 62821 64661 +1840
Branches 9788 10303 +515
=========================================================
+ Hits 41782 42888 +1106
- Misses 18658 19241 +583
- Partials 2381 2532 +151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
force-pushed
the
fix-discover-legacy-functional-tests
branch
from
5568f6c
to
e6c906e
Compare
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
ashwin-pc
approved these changes
Aug 16, 2023
| @@ -88,6 +95,8 @@ export default function ({ getService, getPageObjects }) { | |||
| expect(colorChoiceRetained).to.be(true); | |||
| }); | |||
|
|
|||
| // the following three tests are skipped because of save search save window bug: | |||
There was a problem hiding this comment.
I see the comment but not the skip. Did you leave this in here accidentally?
Comment on lines
+138
to
+140
| // Have to add steps to actually click on the dashboard; since added browser.refresh() will make | ||
| // clickDashboard() to only land on the dashboard listing page | ||
| // We need to add browser.refresh() so clickDiscover() lands correctly on the legacy discover page |
There was a problem hiding this comment.
Not for right now but when we remove Legacy discover in 2.11, is it easy enough to migrate these to Discover 2.0?
ashwin-pc
merged commit 8ee9c91
into
opensearch-project:feature/data-explorer
46 of 49 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure all the original functional tests pass for the legacy discover plugin.
Issues Resolved
#4653
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr