Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Saved object integration #4745

Merged

Conversation

ashwin-pc
Copy link
Member

Description

This change has a few changes in one. The primary change is allowing data explorer to open, edit and save saved objects. The main chnages are:

  1. Add the top nav links for Discover 2.0:
    • Create a new saved search
    • Save the search
    • Open saved searches
    • Share the search
    • Inspect a search
  2. Fixes issue where navigating away from the app causes memory leaks
  3. minor fixes with padding

Issues Resolved

Screenshot

Screen.Recording.2023-08-15.at.4.57.43.PM.mov

Testing the changes

  • Pull the change
  • Load sample data for flight logs
  • Open any of the saved searches or create your own

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4745 (0fe7648) into feature/data-explorer (521f306) will decrease coverage by 0.21%.
Report is 4 commits behind head on feature/data-explorer.
The diff coverage is 57.58%.

@@                    Coverage Diff                    @@
##           feature/data-explorer    #4745      +/-   ##
=========================================================
- Coverage                  66.50%   66.30%   -0.21%     
=========================================================
  Files                       3289     3380      +91     
  Lines                      62821    64683    +1862     
  Branches                    9788    10308     +520     
=========================================================
+ Hits                       41782    42888    +1106     
- Misses                     18658    19260     +602     
- Partials                    2381     2535     +154     
Flag Coverage Δ
Linux_1 34.82% <8.96%> (?)
Linux_2 55.04% <84.33%> (?)
Linux_3 43.89% <43.13%> (?)
Linux_4 35.10% <14.56%> (?)
Windows ?
Windows_1 34.83% <8.96%> (?)
Windows_2 55.01% <84.33%> (?)
Windows_3 43.89% <43.13%> (?)
Windows_4 35.10% <14.56%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-babel-preset/node_preset.js 100.00% <ø> (ø)
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...ch-archiver/src/lib/indices/create_index_stream.ts 69.76% <ø> (ø)
...ch-archiver/src/lib/indices/delete_index_stream.ts 50.00% <ø> (ø)
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% <0.00%> (ø)
packages/osd-ui-shared-deps/theme.ts 41.66% <0.00%> (ø)
src/core/server/legacy/legacy_service.ts 75.38% <ø> (ø)
src/core/server/plugins/plugin_context.ts 45.45% <ø> (ø)
src/core/server/rendering/views/template.tsx 100.00% <ø> (ø)
...server/saved_objects/saved_objects_service.mock.ts 100.00% <ø> (ø)
... and 70 more

... and 218 files with indirect coverage changes

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc merged commit 0293262 into opensearch-project:feature/data-explorer Aug 16, 2023
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent distinguished-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants