-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer] Saved object integration #4745
Merged
ashwin-pc
merged 9 commits into
opensearch-project:feature/data-explorer
from
ashwin-pc:saved-search
Aug 16, 2023
Merged
[Data Explorer] Saved object integration #4745
ashwin-pc
merged 9 commits into
opensearch-project:feature/data-explorer
from
ashwin-pc:saved-search
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
ashwin-pc
added
discover
for discover reinvent
de-angular
de-angularize work
data explorer
Issues related to the Data Explorer project
labels
Aug 16, 2023
ashwin-pc
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
August 16, 2023 00:00
Codecov Report
@@ Coverage Diff @@
## feature/data-explorer #4745 +/- ##
=========================================================
- Coverage 66.50% 66.30% -0.21%
=========================================================
Files 3289 3380 +91
Lines 62821 64683 +1862
Branches 9788 10308 +520
=========================================================
+ Hits 41782 42888 +1106
- Misses 18658 19260 +602
- Partials 2381 2535 +154
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
ananzh
approved these changes
Aug 16, 2023
ashwin-pc
merged commit Aug 16, 2023
0293262
into
opensearch-project:feature/data-explorer
46 of 49 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data explorer
Issues related to the Data Explorer project
de-angular
de-angularize work
discover
for discover reinvent
distinguished-contributor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change has a few changes in one. The primary change is allowing data explorer to open, edit and save saved objects. The main chnages are:
Issues Resolved
Screenshot
Screen.Recording.2023-08-15.at.4.57.43.PM.mov
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr