Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer][Discover 2.0] Enable sort and cell actions for table #4787

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Aug 21, 2023

Description

This PR first enable sorting functionality
Screenshot 2023-08-21 at 09 00 17

It also restores cell actions
Screenshot 2023-08-21 at 09 00 26

Issue Resolve

#4775
#4776

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #4787 (b2edd21) into feature/data-explorer (521f306) will decrease coverage by 0.15%.
Report is 10 commits behind head on feature/data-explorer.
The diff coverage is 75.72%.

❗ Current head b2edd21 differs from pull request most recent head 657a5a0. Consider uploading reports for the commit 657a5a0 to get more accurate results

@@                    Coverage Diff                    @@
##           feature/data-explorer    #4787      +/-   ##
=========================================================
- Coverage                  66.50%   66.35%   -0.15%     
=========================================================
  Files                       3289     3390     +101     
  Lines                      62821    64729    +1908     
  Branches                    9788    10306     +518     
=========================================================
+ Hits                       41782    42954    +1172     
- Misses                     18658    19231     +573     
- Partials                    2381     2544     +163     
Flag Coverage Δ
Linux_1 34.91% <82.00%> (?)
Linux_2 55.13% <77.22%> (?)
Linux_4 35.10% <82.00%> (?)
Windows ?
Windows_1 34.92% <82.00%> (?)
Windows_2 55.10% <77.22%> (?)
Windows_3 43.97% <81.63%> (?)
Windows_4 35.10% <82.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-babel-preset/node_preset.js 100.00% <ø> (ø)
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...ch-archiver/src/lib/indices/create_index_stream.ts 69.76% <ø> (ø)
...ch-archiver/src/lib/indices/delete_index_stream.ts 50.00% <ø> (ø)
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% <0.00%> (ø)
packages/osd-pm/src/utils/package_json.ts 66.66% <ø> (ø)
packages/osd-ui-shared-deps/theme.ts 41.66% <0.00%> (ø)
src/core/public/chrome/chrome_service.mock.ts 100.00% <ø> (ø)
...c/core/public/chrome/ui/header/collapsible_nav.tsx 95.45% <ø> (+0.90%) ⬆️
src/core/public/chrome/ui/header/header.tsx 75.00% <ø> (+1.66%) ⬆️
... and 37 more

... and 317 files with indirect coverage changes

@ashwin-pc ashwin-pc added discover for discover reinvent de-angular de-angularize work data explorer Issues related to the Data Explorer project labels Aug 21, 2023
@ananzh ananzh force-pushed the feature/data-explorer-table-sort branch from 392afb5 to b2edd21 Compare August 25, 2023 22:27
@ananzh ananzh requested a review from curq as a code owner August 25, 2023 22:27
@ananzh ananzh force-pushed the feature/data-explorer-table-sort branch from b2edd21 to 56f3330 Compare August 25, 2023 22:31
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashwin-pc
Copy link
Member

Looks like some snapshots are failing in ciGroup3

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh merged commit 8766395 into opensearch-project:feature/data-explorer Aug 26, 2023
39 checks passed
ashwin-pc pushed a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Aug 26, 2023
…pensearch-project#4787)

* [Data Explorer][Discover 2.0] Enable sort and cell actions for table

Signed-off-by: ananzh <ananzh@amazon.com>

* update test snapshot

Signed-off-by: ananzh <ananzh@amazon.com>

---------

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit 8766395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent distinguished-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants