Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kbn-i18n to osd-i18n (#37) #48

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Rename kbn-i18n to osd-i18n (#37) #48

merged 1 commit into from
Mar 4, 2021

Conversation

boktorbb
Copy link
Contributor

@boktorbb boktorbb commented Mar 3, 2021

Signed-off-by: Bishoy Boktor boktorbb@amazon.com

Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see new file of GuideLine.md. Was this removed purposefully ?

@boktorbb
Copy link
Contributor Author

boktorbb commented Mar 4, 2021

I don't see new file of GuideLine.md. Was this removed purposefully ?

It's there for me. The file was renamed

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@boktorbb boktorbb merged commit e24d6ba into opensearch-project:dashboards Mar 4, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants