[NodeJS18 Upgrade] Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version and update changelog of 2.9.0/Unreleased Sections #4948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
peterzhuamazon
changed the title
peterzhuamazon
changed the title
This was referenced Sep 6, 2023
peterzhuamazon
changed the title
peterzhuamazon
added
>upgrade
release
nodejs 🍭
AMoo-Miki
reviewed
Sep 6, 2023
There was a problem hiding this comment.
We don't use this file and I would love to get rid of it; if Infra uses it for anything, let's work together and change them to use .nvmrc instead and then remove this file.
There was a problem hiding this comment.
We do not use this file at all.
But I would say probably remove in main before remove in 2.x.
Thanks.
There was a problem hiding this comment.
yeah probably worth merit to open an issue @AMoo-Miki to verify usage of this.
AMoo-Miki
approved these changes
Sep 6, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #4948 +/- ##
=======================================
Coverage 66.44% 66.44%
=======================================
Files 3399 3399
Lines 64881 64881
Branches 10360 10360
=======================================
Hits 43107 43107
Misses 19215 19215
Partials 2559 2559
Flags with carried forward coverage won't be shown. Click here to find out more. |
bbarani
approved these changes
Sep 6, 2023
kavilla
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[NodeJS18 Upgrade] Bump OpenSearch-Dashboards 2.10.0 to use nodejs 18.16.0 version and update changelog of 2.9.0/Unreleased Sections
Issues Resolved
opensearch-project/opensearch-build#1563
opensearch-project/opensearch-build#3743
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr