[1.3][CVE-2022-33987] Partially fix security issues for got by bumping @elastic/makelogs from 6.0.0 to 6.1.1 and update yarn.lock

[ananzh]

With the SemVer philosophy, when releasing a patch version, it should not introduce breaking changes, which includes bumping a dependency to its major version.

got is a not a direct dependency for OSD. Meanwhile, it is not included in release artifact. Therefore, bumping major versions should not break SemVer rules.

Description

This CVE requires to update got to 11.8.5 or 12.1.0. got is used in multiple versions:
3.3.1
5.6.0
6.7.1
7.1.0
8.3.2
9.6.0
11.8.2

This PR only fixed the two acceptable changes. Other versions are not fixable in 1.3.

got@6.7.1

Hoisted from dependencies "project#latest-version#package-json#got" and "project#@osd#ui-framework#yeoman-generator#github-username#gh-got#got"

• @osd-ui-framework uses yeoman-generator@^4.13.0. This is already the highest node compatible version. yeoman-generator@^5.0.0 requests node>=12: https://github.com/yeoman/generator/blob/v5.0.0-beta.1/package.json#L45
• latest-version#package-json#got is from yo from @osd-ui-framework. We have yo@2.0.6 and the highest compatible version we support is 3.1.1 (https://github.com/yeoman/yo/blob/v3.1.1/package.json). Since 4.0.0, yo requires node version >=12. After bump to 3.1.1, still see got@6.7.1 . This change is useless.

got@5.6.0

This exists because "project#geckodriver" depends on it.

• We use geckodriver@^1.21.0. The highest compatible version we could support is 1.22.3. After bump, still see got@5.6.0. This change is useless.

got@11.8.2

This exists because "project#ms-chromium-edge-driver" depends on it.

• We use ms-chromium-edge-driver@^0.4.3, which has got^11.8.2 https://github.com/dmlemeshko/ms-edge-driver/blob/0.4.3/package.json#L37. This include the version we need. Just need to clean yarn.lock and bootstrap. After bump, got is using 11.8.6. This is an acceptable change.

got@8.3.2

Hoisted from dependency "project#@osd#ui-framework#yo#package-json#got".

• We have yo@2.0.6 and the highest compatible version we support is 3.1.1 (https://github.com/yeoman/yo/blob/v3.1.1/package.json). Since 4.0.0, yo requires node version >=12. Bump to 3.1.1 still see got@8.3.2 for @osd#ui-framework#yo#package-json#got". This is a useless change.

got@7.1.0

This exists because "project#@osd#ui-framework#yo#npm-keyword" depends on it.

• Same as above. Bump to 3.1.1 still see got@7.1.0 for @osd#ui-framework#yo#npm-keyword#got. This is a useless change.

got@3.3.1

Hoisted from dependency "project#@elastic#makelogs#update-notifier#latest-version#package-json#got".

• We use @elastic/makelogs@6.0.0. The highest version we could support is 6.1.1. Should bump this package to 6.1.1. Bump to @elastic/makelogs@6.1.1 removes got@3.3.1. This is an acceptable change.

got@9.6.0

Hoisted from dependency "project#@elastic#safer-lodash-set#tsd#update-notifier#latest-version#package-json#got".

• We use tsd@0.16.0 in @elastic/safer-lodash-set which is already the highest compatible version. tsd requires node>=12 since 0.17.0 https://github.com/SamVerschueren/tsd/blob/v0.17.0/package.json#L16

Issues Resolved

CVE-2022-33987
#1764

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Merging #5006 (4248a1d) into 1.3 (7b922e8) will increase coverage by 0.03%.
Report is 1 commits behind head on 1.3.
The diff coverage is n/a.

❗ Current head 4248a1d differs from pull request most recent head 787ebf8. Consider uploading reports for the commit 787ebf8 to get more accurate results

@@            Coverage Diff             @@
##              1.3    #5006      +/-   ##
==========================================
+ Coverage   67.46%   67.49%   +0.03%     
==========================================
  Files        3044     3044              
  Lines       58692    58692              
  Branches     8902     8902              
==========================================
+ Hits        39595    39617      +22     
+ Misses      16945    16926      -19     
+ Partials     2152     2149       -3     

Flag	Coverage Δ
Linux	67.45% <ø> (-0.01%)	⬇️
Windows	67.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

[joshuarrrr]

should be in section under L10.

[ananzh]

yeah 😢