Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run plugin functional tests within Github #5371

Closed

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Oct 25, 2023

Description

Previously Plugin functional tests were not execute within the Github actions.

Building and running the tests with:

node scripts/functional_tests.js --config test/plugin_functional/config.js

Issues Resolved

n/a

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Previously Plugin functional tests were not execute within
the Github actions.

Building and running the tests with:
```
node scripts/functional_tests.js --config test/plugin_functional/config.js
```

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
abbyhu2000 and others added 5 commits October 25, 2023 02:15
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…ch-Dashboards-1 into kavilla/add_plugin_func
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #5371 (ba653ab) into main (e1db842) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head ba653ab differs from pull request most recent head e9ce23e. Consider uploading reports for the commit e9ce23e to get more accurate results

@@           Coverage Diff           @@
##             main    #5371   +/-   ##
=======================================
  Coverage   66.81%   66.81%           
=======================================
  Files        3286     3286           
  Lines       63148    63148           
  Branches    10054    10054           
=======================================
+ Hits        42191    42193    +2     
- Misses      18475    18478    +3     
+ Partials     2482     2477    -5     
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.25% <ø> (ø)
Linux_3 43.82% <ø> (ø)
Linux_4 35.34% <ø> (ø)
Windows_1 35.25% <ø> (ø)
Windows_2 55.22% <ø> (ø)
Windows_3 43.83% <ø> (+<0.01%) ⬆️
Windows_4 35.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@abbyhu2000
Copy link
Member

Will be resolves in #5383

@abbyhu2000 abbyhu2000 closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants