-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look and feel enhancements - Batch 1 #5766
Closed
AMoo-Miki
wants to merge
8
commits into
opensearch-project:feature/table-revert
from
AMoo-Miki:table-revert-batch-1
Closed
Look and feel enhancements - Batch 1 #5766
AMoo-Miki
wants to merge
8
commits into
opensearch-project:feature/table-revert
from
AMoo-Miki:table-revert-batch-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
January 31, 2024 20:17
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/table-revert #5766 +/- ##
=====================================================
Coverage 67.02% 67.02%
=====================================================
Files 3296 3296
Lines 63345 63345
Branches 10089 10089
=====================================================
Hits 42458 42458
Misses 18433 18433
Partials 2454 2454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Also: * adjust the width of non-wrapped cells Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
table-revert-batch-1
branch
from
February 1, 2024 06:01
f1c6330
to
95bcdd4
Compare
ashwin-pc
reviewed
Feb 1, 2024
src/plugins/discover/public/application/components/default_discover_table/table_cell.tsx
Show resolved
Hide resolved
src/plugins/discover/public/application/components/default_discover_table/_table_cell.scss
Show resolved
Hide resolved
src/plugins/discover/public/application/components/default_discover_table/_table_cell.scss
Show resolved
Hide resolved
src/plugins/discover/public/application/components/default_discover_table/_table_cell.scss
Show resolved
Hide resolved
src/plugins/discover/public/application/components/default_discover_table/table_rows.tsx
Show resolved
Hide resolved
src/plugins/discover/public/application/components/default_discover_table/table_rows.tsx
Show resolved
Hide resolved
src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss
Show resolved
Hide resolved
src/plugins/discover/public/application/components/default_discover_table/_doc_table.scss
Show resolved
Hide resolved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Discover] Vertically align expansion arrows
[Discover] Clamp the amount of data shown in a row
[Discover] Display filter buttons at top right of the cell
[Discover] Prevent wrapping of date fields
Use
ouiCodeFont
in Discover and reduce text size[Discover] Vertically align source cells with others
Revert the breadcrumb of Discover to be a link rather than a button
Vertically align the text in osdQueryBar with other elements on the page
Check List
yarn test:jest
yarn test:jest_integration