Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Support local cluster by default #5811

Conversation

xinruiba
Copy link
Member

@xinruiba xinruiba commented Feb 6, 2024

Description

When MD enabled, local cluster should be enabled by default

Issues Resolved

#5754

Screenshot

Screenshot 2024-02-05 at 6 34 05 PM

Testing the changes

Tested when

  1. data_source.enabled = true
  2. data_source.defaultCluster get comment out

We still able to add sample data successfully in local cluster

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (510c759) 66.78% compared to head (d2ce8a6) 66.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5811      +/-   ##
==========================================
+ Coverage   66.78%   66.92%   +0.13%     
==========================================
  Files        2591     3302     +711     
  Lines       48749    63505   +14756     
  Branches     8765    10140    +1375     
==========================================
+ Hits        32557    42500    +9943     
- Misses      14054    18540    +4486     
- Partials     2138     2465     +327     
Flag Coverage Δ
Linux_2 55.11% <ø> (ø)
Linux_3 43.83% <ø> (ø)
Linux_4 ?
Windows_1 35.25% <ø> (?)
Windows_3 43.85% <ø> (?)
Windows_4 35.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
@bandinib-amzn
Copy link
Member

Can you be more specific on what part of the issue #5754 this PR cover? I believe it doesn't entirely resolves #5754, right? If you wanna split into smaller tasks, I suggest to create something similar to meta issue

@bandinib-amzn bandinib-amzn added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed first-time-contributor labels Feb 6, 2024
@xinruiba
Copy link
Member Author

xinruiba commented Feb 6, 2024

Can you be more specific on what part of the issue #5754 this PR cover? I believe it doesn't entirely resolves #5754, right? If you wanna split into smaller tasks, I suggest to create something similar to meta issue

Thanks for the comment.

This change is to enabled local cluster by default when "data_source.enabled = true" and "data_source.defaultCluster" is commented out.

I've update the related info under this task #5696 and we can use it as the meta issue.

Thanks~

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
@bandinib-amzn bandinib-amzn force-pushed the xinrui_updateLocalClusterDefaultValue branch from cb61189 to d2ce8a6 Compare February 6, 2024 21:12
@ZilongX ZilongX merged commit 1eb2f8b into opensearch-project:main Feb 6, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants