Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Datasource id is required if multiple datasource is enabled and no default cluster supported #5842

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bbd40e1 from #5751.

…fault cluster supported (#5751)

* datasource id is required if multiple datasource is enabled and no default cluster supported

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

---------

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
(cherry picked from commit bbd40e1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (040a7f0) 66.94% compared to head (ee6aa79) 66.99%.

Files Patch % Lines
...a/server/search/opensearch_search/decide_client.ts 66.66% 0 Missing and 1 partial ⚠️
...ch/opensearch_search/opensearch_search_strategy.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #5842      +/-   ##
==========================================
+ Coverage   66.94%   66.99%   +0.05%     
==========================================
  Files        3300     3300              
  Lines       63545    63548       +3     
  Branches    10131    10134       +3     
==========================================
+ Hits        42539    42577      +38     
+ Misses      18546    18515      -31     
+ Partials     2460     2456       -4     
Flag Coverage Δ
Linux_1 35.23% <0.00%> (-0.01%) ⬇️
Linux_2 55.15% <0.00%> (-0.01%) ⬇️
Linux_3 43.86% <75.00%> (+0.01%) ⬆️
Linux_4 35.34% <0.00%> (-0.01%) ⬇️
Windows_1 35.25% <0.00%> (?)
Windows_2 55.12% <0.00%> (?)
Windows_3 43.86% <75.00%> (?)
Windows_4 35.34% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZilongX ZilongX merged commit 2b7fdf2 into 2.x Feb 20, 2024
83 of 88 checks passed
@ZilongX ZilongX deleted the backport/backport-5751-to-2.x branch February 20, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports multiple datasource multiple datasource project v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants