-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty space when resize datagrid table in Discover and Allow saving column width in both Discover and Dashboards Embeddable #5883
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5883 +/- ##
==========================================
- Coverage 67.34% 67.34% -0.01%
==========================================
Files 3352 3352
Lines 65080 65088 +8
Branches 10485 10488 +3
==========================================
+ Hits 43829 43834 +5
- Misses 18699 18701 +2
- Partials 2552 2553 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0e96ece
to
3b0b021
Compare
Signed-off-by: Anan Z <ananzh@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM. Thanks for adding the test :)
We think add this will slow the column resize and might choose a different way to resolve the issue. As synced up with @ashwin-pc, we will put it in 2.14 release. |
@ananzh will remove the 2.14 label as this in draft still. And have added the 2.15 label or if it needs to be closed feel free to do so. |
Hi @ananzh , is this PR targeting 2.15? |
Description
Issues Resolved
#5671
#5726
Screenshot
rm-empty-space-savable-width.mov
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration