Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example demo plugins for cross compatibility and functional tests #5896

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

manasvinibs
Copy link
Member

@manasvinibs manasvinibs commented Feb 19, 2024

Description

This change adds 3 Developer example plugins for demonstrating Cross compatibility core service use cases.

yarn start --run-examples

Cross compatibility Core service details - #4903
Adds functional tests for 3 use cases of plugins:

  1. Example plugin 1 demonstrate success use case where plugin's required engine plugin dependency satisfies and hence plugin registers itself and show in the side navigation. Also plugins can make API calls on button click and degrade themselves if they find the dependencies are incompatible.
  2. Example plugin 2 demonstrate incompatible dependencies where plugin do not register to the side navigation and choose to hide from the menu list.
  3. Example plugin 3 demonstrate incompatible dependencies where plugin decides to register in the side nav but will be disabled.

Issues Resolved

#5889

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.00%. Comparing base (55443f7) to head (a889fe2).
Report is 394 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5896      +/-   ##
==========================================
+ Coverage   66.98%   67.00%   +0.02%     
==========================================
  Files        3304     3305       +1     
  Lines       63569    63574       +5     
  Branches    10153    10153              
==========================================
+ Hits        42580    42597      +17     
+ Misses      18521    18509      -12     
  Partials     2468     2468              
Flag Coverage Δ
Linux_1 35.21% <ø> (ø)
Linux_2 55.11% <ø> (ø)
Linux_3 43.54% <ø> (+<0.01%) ⬆️
Linux_4 35.20% <ø> (ø)
Windows_1 35.27% <ø> (+0.03%) ⬆️
Windows_2 55.07% <ø> (ø)
Windows_3 43.56% <ø> (+<0.01%) ⬆️
Windows_4 35.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
@BionIT
Copy link
Collaborator

BionIT commented Jun 5, 2024

Hi @manasvinibs , are we targeting this PR for future releases?

@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Jun 5, 2024

These being "examples", we needn't tie it to a release but since it also adds tests, I would love to have it in sooner rather than later.

@manasvinibs I haven't gone through the PR yet but could you please lowercase the file names? A rebase would be great too.

@ananzh ananzh added the v2.17.0 label Jul 25, 2024
@sejli
Copy link
Member

sejli commented Aug 30, 2024

Hey @manasvinibs, I see the 2.17.0 label. Is this still being targeted for 2.17.0?

@ananzh
Copy link
Member

ananzh commented Oct 30, 2024

Convert to draft due to no progress.

@ananzh ananzh marked this pull request as draft October 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants