[Rename] kbn-telemetry in packages directory to osd-telemetry-tools #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
boktorbb
previously approved these changes
Mar 4, 2021
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
approved these changes
Mar 4, 2021
| @@ -198,7 +198,7 @@ usageCollection.makeUsageCollector<Usage>({ | |||
| }) | |||
| ``` | |||
|
|
|||
| Be careful adding arrays of objects due to the limitation in correlating the properties inside those objects inside kibana. It is advised to look for an alternative schema based on your use cases. | |||
| Be careful adding arrays of objects due to the limitation in correlating the properties inside those objects inside opesearch-dashboards. It is advised to look for an alternative schema based on your use cases. | |||
There was a problem hiding this comment.
Thanks for catching, fixed.
| const kibanaRoot = process.cwd(); | ||
| const xpackRoot = path.join(kibanaRoot, 'x-pack'); | ||
| const opensearchDashboardsRoot = process.cwd(); | ||
| const xpackRoot = path.join(opensearchDashboardsRoot, 'x-pack'); |
There was a problem hiding this comment.
this is fine that x-pack is in here right?
There was a problem hiding this comment.
Ideally we'll remove on the following efforts to make it completely condition less.
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
…#61) * [Rename] kbn-telemetry in packages directory to osd-telemetry-tools Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] kbn-telemetry in packages directory to osd-telemetry-tools Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] in-corporate review comments Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
) * [Rename] kbn-telemetry in packages directory to osd-telemetry-tools Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] kbn-telemetry in packages directory to osd-telemetry-tools Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] in-corporate review comments Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni
added a commit
that referenced
this pull request
Mar 20, 2021
) * [Rename] kbn-telemetry in packages directory to osd-telemetry-tools Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] kbn-telemetry in packages directory to osd-telemetry-tools Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] in-corporate review comments Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Soni mihirsoni.123@gmail.com
Issue #, if available: #37
Description of changes: kbn-telemetry in packages directory to osd-telemetry-tools
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.